From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9E8C746970F
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 26 Nov 2019 02:04:06 +0300 (MSK)
References: <cover.1574681299.git.i.kosarev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <27284eb5-2a1c-7f49-ef0c-cd2e7d3eb9fd@tarantool.org>
Date: Tue, 26 Nov 2019 00:04:05 +0100
MIME-Version: 1.0
In-Reply-To: <cover.1574681299.git.i.kosarev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 0/4] fix box_set_replication
 issues & stabilize quorum test
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Ilya Kosarev <i.kosarev@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the patchset!

LGTM.

On 25/11/2019 12:50, Ilya Kosarev wrote:
> This patchset fixes appliers pruning in replicaset_update, anon
> replicas iteration issues in replicaset_follow and stabilizes quorum
> test. It also stabilizes tcp_connect in test_run:cmd().
> 
> Changes in v2:
> - fixed mac os specific instability in quorum test
> - added appropriate test case for anon replicas iteration
> - fixed appliers pruning (fail discovered with test case mentioned above)
> - bumped test-run to stabilize tcp_connect in test_run:cmd()
> 
> Changes in v3:
> - simplified mac os specific instability fix in quorum test
> - improved appliers pruning fix
> 
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4586-fix-quorum-test
> Issues: https://github.com/tarantool/tarantool/issues/4586
>         https://github.com/tarantool/tarantool/issues/4643
>         https://github.com/tarantool/tarantool/issues/4576
>         https://github.com/tarantool/tarantool/issues/4440
>         https://github.com/tarantool/test-run/issues/193
> 
> Ilya Kosarev (4):
>   test: update test-run
>   replication: fix appliers pruning
>   replication: make anon replicas iteration safe
>   test: stabilize quorum test conditions
>