From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A4E576ECC0; Tue, 7 Dec 2021 09:49:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A4E576ECC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1638859775; bh=22bB1C+zkKU178c8DhHGMoJQOhY22B+vuBGM75Hgrv8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=XWH8USDrVqLgsOq8BJuSAcYsbKJ5Ov2NQ6pVNqiJXTd4dHqCOELVFW7D5H+6GUPS6 +MS66S2oNAdwOeOo983h/tzdROV3gaeEX4Cg2Jtxbq2RyGPbicP7+gs+S/Wpk781K7 XEN/mTt2B9jPoEdjpLoJcj6w7E2rX36VnZBBUz2s= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4DC446ECC0 for ; Tue, 7 Dec 2021 09:49:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4DC446ECC0 Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1muUI9-0000DI-Jj; Tue, 07 Dec 2021 09:49:33 +0300 Message-ID: <26e0daed-6f28-c5de-eb8c-8c6a70f09560@tarantool.org> Date: Tue, 7 Dec 2021 09:49:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org References: <3274e75ae8fc8a996645991aa2f663a72319aa1f.1638577114.git.v.shpilevoy@tarantool.org> <61db4417-1dc2-a31a-e3e7-4e4d4d10c8ee@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD99816DF0F5D64E804DD11F3B756615DE2CDAB71F3CDD6900B182A05F5380850404C228DA9ACA6FE27FCCF0C875E2345445E32FF779512EDA24AADE3F6E57921C3C6A1E3AA5EF81744 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370D3D68FCEFFDD9EA8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D82EBAEAB548EE8B4EAF880AF08A89C313117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC47272755C61AA17BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEC65AC60A1F0286FE4D0DA9BD313A0613D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3457EE4B4996FC54603F1AB874ED89028C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637B8F435DEDE9E76EBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A58A15F460BDA0D93EEC180567F027715414BD6FCC7D58586BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7506FE1F977233B9BB410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C53592357E805773184BC2A026AF75DE66617FECC6168D196ECC7116151BC1F50F0F9634AF6B052D1D7E09C32AA3244CB2B438758A42BFCCCEFF3F371F3D27771E098CBE561D6343729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojTrkTMKMUi4WHJBr59epGjQ== X-Mailru-Sender: 583F1D7ACE8F49BD1042885CEC987B6B8CE0C70651A9514B5E32FF779512EDA27AD558DE3329E3447019711D9D5B048E1458020726E2BC9FD5ECBA0B92C0A936CDC7563AA7CEBD2872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 1/2] router: drop wait_connected from master discovery X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for explanation. LGTM. On 07.12.2021 02:34, Vladislav Shpilevoy wrote: > Hi! Thanks for the review! > > On 05.12.2021 18:44, Oleg Babin wrote: >> Thanks for your patch. Looks reasonable. >> >> However I have one question. Before this patch if some >> >> connection was down we perform wait_connected and in some >> >> cases it could lead to successful reconnection. Currently we just skip >> >> broken connections and don't try to reconnect. >> >> Could it be a problem or we perform reconnection in another place? >> >> What will be happen if all connections will be down? > All connections use reconnect_after option in netbox. Thus netbox > handles reconnect. If all are down, netbox_wait_connected won't help > either. So you will need to make several master discovery iterations > anyway until one is found. > > Also before this patch netbox_wait_connected() couldn't boost > successful reconnection anyhow. It was just waiting. It didn't affect > the connection state. > > After this patch the waiting is dropped to try to talk to the > disconnected nodes later on a next master discovery iteration.