From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EB63323F0F for ; Wed, 9 Jan 2019 06:39:25 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HK257v61MwF1 for ; Wed, 9 Jan 2019 06:39:25 -0500 (EST) Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3589121460 for ; Wed, 9 Jan 2019 06:39:25 -0500 (EST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: [tarantool-patches] Re: [PATCH] sql: fix lemon memory leak reported by ASAN From: "n.pettik" In-Reply-To: <20190109085733.2gq2c6ru6wrxahav@tkn_work_nb> Date: Wed, 9 Jan 2019 13:39:21 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <26C4820B-1053-403B-AF38-0B35CDAA4E58@tarantool.org> References: <9dbcaa3afae39cc46a8e6da5e00b5d62179ed016.1546692811.git.alexander.turenko@tarantool.org> <20190109072015.gruplrs6gyrcu66w@tarantool.org> <20190109085733.2gq2c6ru6wrxahav@tkn_work_nb> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Alexander Turenko , Kirill Yukhin > On 9 Jan 2019, at 10:57, Alexander Turenko = wrote: >=20 > On Wed, Jan 09, 2019 at 10:20:15AM +0300, Kirill Yukhin wrote: >> Hello, >> On 05 Jan 16:13, Alexander Turenko wrote: >>> It catched by ASAN at build time (lemon is executed to generate >>> parse.[ch]), so tarantool couldn't be built with -DENABLE_ASAN=3DON. >>> --- >>>=20 >>> no issue >>> = https://github.com/tarantool/tarantool/tree/Totktonada/fix-lemon-memleak >> I've pushed your patch into 2.1 branch. >>=20 >> Should we propose a patch to SQLite? >=20 > It is not so important unless you are using ASAN and I think in SQLite > it only run in the maintainer mode. >=20 > SQLite requires to sign-off dedication document before contribute. The > patch I think is not enough reason to do that. You can simply write to sqlite dev list about it: http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-dev