From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9DF7D27661 for ; Mon, 11 Feb 2019 18:53:44 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GKKVzSDB9GsA for ; Mon, 11 Feb 2019 18:53:44 -0500 (EST) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5925327642 for ; Mon, 11 Feb 2019 18:53:44 -0500 (EST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [tarantool-patches] Re: [PATCH 0/2] sql: store statistics in statN as an array of integers From: "n.pettik" In-Reply-To: Date: Tue, 12 Feb 2019 02:53:41 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <263D687D-781B-4479-8F96-30B5FD89EB68@tarantool.org> References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Roman Khabibov Travis status is entirely negative - it can=E2=80=99t be compiled. Please, make sure that at least build is successfully finished before sending patch. > On 27 Jan 2019, at 03:28, Roman Khabibov = wrote: >=20 > It was necessary to add function for msg pack result in sqlite3 VDBE = API. Actually, it wasn=E2=80=99t. You still can use result_blob and set subtype after its invocation. Now it doesn=E2=80=99t matter much. > The patchset is very raw. > There are problems with the old tests that need > to be solved. Ok, could you at least explain or enumerate existing problems (in our char, in ticket comments, wherever you want) and possible solutions. > I do not know if a piece of code with keyword checking works. > Could you send in the reply letter test samples for "unordered" and = "noskipscan" > keywords? What kind of samples do you need? To check that it works you need get plan of query (explain query plan =E2=80=A6), manually update statisctics in _sql_stat space, probably restart instance to load to in-memory structs new statistics and make sure that plan of query has changed. Ofc not all plans will change, but only those which are related to skip-scan optimisation (don=E2=80=99t remember what the second token is responsible for).