From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A2D85445320 for ; Sun, 12 Jul 2020 18:37:33 +0300 (MSK) From: Vladislav Shpilevoy References: <5010f149-6c50-9370-4394-930ed4771a0b@tarantool.org> <0a092699-94c7-7d0b-1719-e1925eea9987@tarantool.org> Message-ID: <261149b0-0eff-8ebc-dda2-059a37e4faeb@tarantool.org> Date: Sun, 12 Jul 2020 17:37:31 +0200 MIME-Version: 1.0 In-Reply-To: <0a092699-94c7-7d0b-1719-e1925eea9987@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 4/6] Fix luacheck warnings in extra/dist/ List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org, imun@tarantool.org Cc: alexander.turenko@tarantool.org When we talked last time, you said you probably fixed it already on the branch, and I could forget to make git reset --hard origin/, but I just checked - nothing is fixed on the branch. On 05.07.2020 18:28, Vladislav Shpilevoy wrote: > I see you made a small fix in one of the commits about > unnecessary diff. However there is still a mess with the > commits. So can't give LGTM yet.