From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 62755445320
 for <tarantool-patches@dev.tarantool.org>;
 Sun,  5 Jul 2020 20:04:14 +0300 (MSK)
References: <1593757997-4145-1-git-send-email-alyapunov@tarantool.org>
 <1593757997-4145-5-git-send-email-alyapunov@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <2601d441-cedb-8f9a-304b-e35d572c83cd@tarantool.org>
Date: Sun, 5 Jul 2020 19:04:12 +0200
MIME-Version: 1.0
In-Reply-To: <1593757997-4145-5-git-send-email-alyapunov@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 04/15] vinyl: rename tx_manager ->
 vy_tx_manager
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Aleksandr Lyapunov <alyapunov@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the patch!

The old name is still used in one place:

src/box/vy_scheduler.h
151: 	/** List of read views, see tx_manager::read_views. */

> diff --git a/src/box/vy_tx.c b/src/box/vy_tx.c
> index 846c632..17c79d6 100644
> --- a/src/box/vy_tx.c
> +++ b/src/box/vy_tx.c
> @@ -1140,7 +1141,7 @@ vy_tx_set(struct vy_tx *tx, struct vy_lsm *lsm, struct tuple *stmt)
>  }
>  
>  void
> -tx_manager_abort_writers_for_ddl(struct tx_manager *xm, struct space *space,
> +vy_tx_manager_abort_writers_for_ddl(struct vy_tx_manager *xm, struct space *space,
>  				 bool *need_wal_sync)

The indentation is broken here.