From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 70E616F3C4; Mon, 10 May 2021 21:42:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 70E616F3C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620672146; bh=p8CBTcYq2A5qZESa2USezLGmABD/e4eK2iZGIZndXxo=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=EScl26kxGXOC0KWX7zujICmEtk4OBsD9/K+g9jBStn4mPArpS9NJxGAknD1rd27E5 nQ1AH5O7thmcjpPsTH6Qv4p+76YssOsRpG0yYeeCVa6durw+75CncO5KwCTTXHpg6g OnlThVBewNH0nLuVVG1AjlsSORTN9sNqhlVXq2+I= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C392C6F816 for ; Mon, 10 May 2021 21:40:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C392C6F816 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1lgApW-0007zL-Q1; Mon, 10 May 2021 21:40:35 +0300 To: Cyrill Gorcunov , tml References: <20210504155819.290874-1-gorcunov@gmail.com> <20210504155819.290874-11-gorcunov@gmail.com> Message-ID: <25ed7418-5dfa-1650-ee92-94dc644a7934@tarantool.org> Date: Mon, 10 May 2021 20:40:34 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210504155819.290874-11-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0890FB394E039F71AA2C815CBBA0C08E7182A05F5380850404A3E65F1200AB8BA1050260FF3514A580E1003F525D682059C7BCEA2493708FF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75644E22E05AA81AEB287FD4696A6DC2FA8DF7F3B2552694A4E2F5AFA99E116B42401471946AA11AF176DF2183F8FC7C0C8F626AC60F7C5938F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB5533756608CF033E463A50885F382A0B7844ADD583133222FFD444E4A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C390D92131081DE748117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF78869D5A527682C5BA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B6F200C74C08DAA5FC76E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C565C1E6824D8037B43847C11F186F3C59DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4AD06F486128ED73FA78D8A4A043D5F5BF2 X-C1DE0DAB: 0D63561A33F958A5453C38BD14CDDEE20C6EDEAC24477203893F8102D54BCEC3D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34753B45383CEFF20458FD2BD0A570362D29F463D1ACF746FD55B17E02DF02CF015C57546F57CCB4A61D7E09C32AA3244CCF33F1A57EDB92DFAA9B9412EC735EAB33C9DC155518937F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojW8rfvRc3+Ao+As3YXYj2lg== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA311024A4BC108AE990B236EF7EAFF26C66E008E827A8DCDADF6A07784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 10/10] say: fix CFORMAT specification X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! On 04.05.2021 17:58, Cyrill Gorcunov wrote: > The position of first argument to check from is 6, not 0. > Looks like our tests with CFORMAT was simply not working > since commit 7d12d66e67a1ce843a2712980f4d3ba04bc0d4f2. Please, in addition to the hash add the commit title in parentheses. https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message > Lets turn them all back. > > Part-of #5846