From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 75F73162410F; Thu, 15 Jan 2026 10:52:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 75F73162410F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1768463550; bh=po/00xcEODXnLFVjVFN/r6+BQxnPhsNzbsjDYfUDhEY=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=CiEsr6SLOJhmh9xQ3a8A7aNcp5oawAP+0AFFnH+6O7Y7V+I1+Ph8bZ9t+caE2oSVu XEwv8PR8Na3gfD/iH1oZz/k7r1fYj8bj9WOUE5l7l4LM5oBsSjQtdSQUwbfPKw9OO+ b/EMj3c+y07ue0p/ACIA4caQOUoFl25UIS1mKA9M= Received: from send242.i.mail.ru (send242.i.mail.ru [95.163.59.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 386B9162410F for ; Thu, 15 Jan 2026 10:52:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 386B9162410F Received: by exim-smtp-55f9c6db88-rqk4q with esmtpa (envelope-from ) id 1vgI9c-000000002mz-0TnE; Thu, 15 Jan 2026 10:52:28 +0300 Content-Type: multipart/alternative; boundary="------------CQ1Aqch1LbniFw1KDY7CNgPa" Message-ID: <25a553ad-8c97-465f-867d-7a779c8626f7@tarantool.org> Date: Thu, 15 Jan 2026 10:52:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <17eca2e353ca35724c022af610f1295328838561.1766738771.git.skaplun@tarantool.org> <86be55de-2fc3-4847-9d32-60682c9f6db2@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD99B884C1B59F9AF802ED9356C6850F66561FA53D3A32280E9182A05F538085040EA95A556D80927633DE06ABAFEAF6705B93640432460A7D6A3281B6BB245D3B54ED6240D679448A3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7956F10FFCC7409BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756680939BF45BBEA696134C6D4BFF4371E2F64D354F01AEF1EEFA416BC2E249C17B389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE76515C59FC18CEA6D731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5C888E4C94FA94D355002B1117B3ED69698A1EFBBB0C02F8EE772F934B9BCD185823CB91A9FED034534781492E4B8EEADCF86CE9B81855096 X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659A428BC58B934B21A81672C1FDEDAD23FEDEE111F0968009BBCCADA5A7E62D0927A74F30C2A5F3A5AB8341EE9D5BE9A0AEFF20D0B69196B2CE7CFD6FD3B9AAEE80396FB5C6A889E298CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVVt0N+pdRHOZOy8PzgwBNtU= X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD20F5CCD68872AFA91C5D5B4A3017A8D9B380A3E38B432A761EF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 39/41] perf: add a script for the environment setup X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------CQ1Aqch1LbniFw1KDY7CNgPa Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey! LGTM but see the answer below Sergey On 1/13/26 18:46, Sergey Kaplun wrote: > Hi, Sergey, > Thanks for the comment. > See my thoughts below. > > On 13.01.26, Sergey Bronnikov wrote: >> Hi, Sergey, >> >> thanks for the patch! LGTM with minor comment below. >> >> Sergey >> >> On 12/26/25 12:18, Sergey Kaplun wrote: >>> The patch adds a script for setting the environment before running >>> performance tests. The script originated from the Tarantool's repository >>> [2]. Most of the settings are taken from the Tarantool's wiki page >>> dedicated to the benchmarking [1]. >>> >>> [1]:https://github.com/tarantool/tarantool/blob/dcdb3ee83b3d6324011e704b5a3f4ee3e19bbf47/perf/tools/setup_env.sh >>> [2]:https://github.com/tarantool/tarantool/wiki/Benchmarking >>> --- >>> perf/helpers/setup_env.sh | 135 ++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 135 insertions(+) >>> create mode 100755 perf/helpers/setup_env.sh >>> >>> diff --git a/perf/helpers/setup_env.sh b/perf/helpers/setup_env.sh >>> new file mode 100755 >>> index 00000000..043d3c88 >>> --- /dev/null >>> +++ b/perf/helpers/setup_env.sh >>> @@ -0,0 +1,135 @@ >>> +#!/bin/sh >> I propose to add a note to the comments that the original version of >> script is in the tarantool repository. > Is it necessary? No, actually. > I'm not sure that we keep them intact since LuaJIT and Tarantool may > require different setups. Also, the origin of the file is mentioned in > the commit message. I'm afraid using different configurations on a single computer will be difficult. We always use the same OS (we don't reinstall it before each test), and if scripts from different projects mutate without restoring that state, we could quickly lose reproducibility. >>> + >>> +# The script sets up a Linux operating system before running >>> +# LuaJIT benchmarks. See more details in [1]. >>> +# >>> +# [1]:https://github.com/tarantool/tarantool/wiki/Benchmarking >>> + > > --------------CQ1Aqch1LbniFw1KDY7CNgPa Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey!

LGTM but see the answer below

Sergey

On 1/13/26 18:46, Sergey Kaplun wrote:
Hi, Sergey,
Thanks for the comment.
See my thoughts below.

On 13.01.26, Sergey Bronnikov wrote:

Hi, Sergey,

thanks for the patch! LGTM with minor comment below.

Sergey

On 12/26/25 12:18, Sergey Kaplun wrote:

The patch adds a script for setting the environment before running
performance tests. The script originated from the Tarantool's repository
[2]. Most of the settings are taken from the Tarantool's wiki page
dedicated to the benchmarking [1].

[1]:https://github.com/tarantool/tarantool/blob/dcdb3ee83b3d6324011e704b5a3f4ee3e19bbf47/perf/tools/setup_env.sh
[2]:https://github.com/tarantool/tarantool/wiki/Benchmarking
---
  perf/helpers/setup_env.sh | 135 ++++++++++++++++++++++++++++++++++++++
  1 file changed, 135 insertions(+)
  create mode 100755 perf/helpers/setup_env.sh

diff --git a/perf/helpers/setup_env.sh b/perf/helpers/setup_env.sh
new file mode 100755
index 00000000..043d3c88
--- /dev/null
+++ b/perf/helpers/setup_env.sh
@@ -0,0 +1,135 @@
+#!/bin/sh

I propose to add a note to the comments that the original version of 
script is in the tarantool repository.

Is it necessary?
No, actually. 
I'm not sure that we keep them intact since LuaJIT and Tarantool may
require different setups. Also, the origin of the file is mentioned in
the commit message.
I'm afraid using different configurations on a single computer will be difficult.
We always use the same OS (we don't reinstall it before each test),
and if scripts from different projects mutate without restoring that state,
we could quickly lose reproducibility. 


      

        

          
+
+# The script sets up a Linux operating system before running
+# LuaJIT benchmarks. See more details in [1].
+#
+# [1]:https://github.com/tarantool/tarantool/wiki/Benchmarking
+


        

      

      
<snipped>



    

  
  


--------------CQ1Aqch1LbniFw1KDY7CNgPa--