Hi, Sergey!
LGTM but see the answer below
Sergey
No, actually.Hi, Sergey, Thanks for the comment. See my thoughts below. On 13.01.26, Sergey Bronnikov wrote:Hi, Sergey, thanks for the patch! LGTM with minor comment below. Sergey On 12/26/25 12:18, Sergey Kaplun wrote:The patch adds a script for setting the environment before running performance tests. The script originated from the Tarantool's repository [2]. Most of the settings are taken from the Tarantool's wiki page dedicated to the benchmarking [1]. [1]:https://github.com/tarantool/tarantool/blob/dcdb3ee83b3d6324011e704b5a3f4ee3e19bbf47/perf/tools/setup_env.sh [2]:https://github.com/tarantool/tarantool/wiki/Benchmarking --- perf/helpers/setup_env.sh | 135 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 135 insertions(+) create mode 100755 perf/helpers/setup_env.sh diff --git a/perf/helpers/setup_env.sh b/perf/helpers/setup_env.sh new file mode 100755 index 00000000..043d3c88 --- /dev/null +++ b/perf/helpers/setup_env.sh @@ -0,0 +1,135 @@ +#!/bin/shI propose to add a note to the comments that the original version of script is in the tarantool repository.Is it necessary?
I'm not sure that we keep them intact since LuaJIT and Tarantool may require different setups. Also, the origin of the file is mentioned in the commit message.
+ +# The script sets up a Linux operating system before running +# LuaJIT benchmarks. See more details in [1]. +# +# [1]:https://github.com/tarantool/tarantool/wiki/Benchmarking +<snipped>