From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B8533275CF for ; Thu, 29 Aug 2019 06:40:28 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qkjcgLsesTxF for ; Thu, 29 Aug 2019 06:40:28 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2253226F8D for ; Thu, 29 Aug 2019 06:40:28 -0400 (EDT) From: Georgy Kirichenko Subject: [tarantool-patches] Re: [PATCH] Iproto call won't leak if transaction isn't committed Date: Thu, 29 Aug 2019 13:40:22 +0300 Message-ID: <2590244.QOq6tyCcFF@localhost> In-Reply-To: <4468891.FtR9PfF7uI@localhost> References: <20190828143235.44805-1-maria.khaydich@tarantool.org> <4468891.FtR9PfF7uI@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5962772.me148p98bG"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Maria Khaydich --nextPart5962772.me148p98bG Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Merged to 2.1 On Thursday, August 29, 2019 11:28:14 AM MSK Georgy Kirichenko wrote: > Merged into 2.3, 2.2 and 1.10 as it affects all this versions > > On Wednesday, August 28, 2019 5:32:35 PM MSK Maria Khaydich wrote: > > In case of throwing client error because of unfinished > > transaction we did not destroy used port. It could possibly > > cause huge memory leaks as could be seen with top or its > > analogues when performing net.box test run in a loop. > > > > Closes #4388 > > --- > > Issue: > > https://github.com/tarantool/tarantool/issues/4388 > > Branch: > > https://github.com/tarantool/tarantool/tree/eljashm/gh-4388-uncommitted-ip > > ro to-leaks-not > > > > src/box/call.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/box/call.c b/src/box/call.c > > index ac2bf3004..169210767 100644 > > --- a/src/box/call.c > > +++ b/src/box/call.c > > @@ -132,6 +132,7 @@ box_process_call(struct call_request *request, struct > > port *port) > > > > if (txn != NULL) { > > > > diag_set(ClientError, ER_FUNCTION_TX_ACTIVE); > > > > + port_destroy(port); > > > > txn_rollback(txn); > > fiber_gc(); > > return -1; --nextPart5962772.me148p98bG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEFZT35EtIMRTDS5hJnoTdFFzh6LUFAl1nq5YACgkQnoTdFFzh 6LVu+AgApq2Fh6y+K+TNvpPbZ3XaNPg3rwe4s7yTkaZPpqrLX0DZZo5iBZ4I9kl7 8PGXIpry4TSJ77bWwXSKnAVe16/n5AWqeVo50EDtZUGpkTLwszaqdZXYfoM5+wOc pzeJJyn+Qro8FNJR5vAVNRqB6ajtbkoevxeDzTAR51gp+/WLQHeQOx1sDuuU692G 3guTs8MbSKq+fUZABD35WydXt2MdVn1PgpyAs55j+eyb8NW2TqUUH5BHwNPE8qk9 7Ko3TEFc7ixWPaacyWvjwREuZ7C0KgzRYItZdCrwKIMpPiwLOd8j8xiNJYhuVTg0 glmCdSDiEQa2a4oyr2t7wSFa5do8WQ== =RNiY -----END PGP SIGNATURE----- --nextPart5962772.me148p98bG--