From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C036616AEDEB; Fri, 13 Mar 2026 17:32:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C036616AEDEB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1773412369; bh=iWuQIKsUeJyaznysuPoipxHn5DkSh2ntIaojNifqOTI=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=JSgI0UOQ+UCTQkzwPlG76tue2U5CPMdLwg5w2AiAaaHdV/iMa1pwkveVBhdd43jZR wN1fbRj1ZJeRVXQBLRMwMd5QYTOJCJNUfLfe0Pu7zzBUcKqY1ptxACDUiL0mDr2498 T0Qa57VMB7g+K3NLsedbYvDA7RtU+ParUiInHz6I= Received: from send58.i.mail.ru (send58.i.mail.ru [89.221.237.153]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B64F516AEDE8 for ; Fri, 13 Mar 2026 17:32:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B64F516AEDE8 Received: by exim-smtp-64cdfc6c8d-lz2n2 with esmtpa (envelope-from ) id 1w13ZH-00000000THD-3GCa; Fri, 13 Mar 2026 17:32:48 +0300 Content-Type: multipart/alternative; boundary="------------OgF2YaWxGjr5sHt0STJ8GopZ" Message-ID: <256a4bfa-edea-4971-b5c3-3b94a102c6d9@tarantool.org> Date: Fri, 13 Mar 2026 17:32:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <334e8dd174e6f4c9a03b3a5827c36d5353a85238.1773330679.git.skaplun@tarantool.org> <4454d7e1-43a6-4151-b39f-26fec9a7f04d@tarantool.org> Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91ABAE9865AC7DC882F01B7BC762AAFC9E18D11AB4CF03170182A05F538085040179055E1B4AC74033DE06ABAFEAF6705F432B179208249D93CFA0A272F8203FB049A14F81E47D748 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76042E2DB3E33BF2BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375661EAFBE79684C2D41A01F8C144D746D58C65958D59F6053529A5DD5502522F307389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B65FF0BFC5AEE34BE6CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE76515C59FC18CEA6D731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A555C1F417855410455002B1117B3ED696F114580C4ADFE934250A03108B67251B823CB91A9FED034534781492E4B8EEADB1D70E2111C441FFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659EC8BC24E6327578290329050814F2DC814938C60AAA92360EA4CD4D93BEFAEF564DC2885A4AF3B25B8341EE9D5BE9A0A75FC7FADBE8D1213E5056E2956F5188BFC549288F259A0028CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdbVVJCphTR/iyl6BRsPkgE= X-DA7885C5: 7482F588D23A8D8EF255D290C0D534F9BFBF5CB986563689F7E5C1F824C71994F8BE60302D08B7395B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE292DDD0E6B60A02895345FB5B21D39E7AE840F5D7F4D8908EEF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Prevent recording of loops with -0 step or NaN values. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------OgF2YaWxGjr5sHt0STJ8GopZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the fixes! Sergey On 3/13/26 13:07, Sergey Kaplun wrote: >>> +local function test_trace_recorded(test_payload) >>> + jit.flush() >>> + -- Reset hotcounters. >> nit: comment can be omitted > I prefer not to. There may be the question: why we don't declare this > parameters once? The reason is that the hotcounters may cause collisions > and lead to the false-positive tests failures. Should I make the comment > more verbose? We reset hotcounters in tests about 470 times (grep -R -B 1 "hotloop=1" test | wc -l) and only 15 times we add a comment like "Reset hotcounters.". You add a comment here but missed it in the patch "MIPS64: Avoid unaligned load in lj_vm_exit_interp.". Why we should leave comment here and omit it the aforementioned patch? I'll not insist removing it, just interesting, it is not an issue for blocking merge. > --------------OgF2YaWxGjr5sHt0STJ8GopZ Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the fixes!

Sergey

On 3/13/26 13:07, Sergey Kaplun wrote:


<snipped>

+local function test_trace_recorded(test_payload)
+  jit.flush()
+  -- Reset hotcounters.

nit: comment can be omitted

I prefer not to. There may be the question: why we don't declare this
parameters once? The reason is that the hotcounters may cause collisions
and lead to the false-positive tests failures. Should I make the comment
more verbose?

We reset hotcounters in tests about 470 times (grep -R -B 1 "hotloop=1" test | wc -l) and only

15 times we add a comment like "Reset hotcounters.". You add a comment here but missed it in the patch

"MIPS64: Avoid unaligned load in lj_vm_exit_interp.". Why we should leave comment here and

omit it the aforementioned patch? I'll not insist removing it, just interesting, it is not an issue for blocking merge.
<snipped> 

    

  
  


--------------OgF2YaWxGjr5sHt0STJ8GopZ--