From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9856724556
	for <tarantool-patches@freelists.org>; Sun, 24 Jun 2018 16:42:58 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id EFgsAgHmU8T8 for <tarantool-patches@freelists.org>;
	Sun, 24 Jun 2018 16:42:58 -0400 (EDT)
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id F0A1D24553
	for <tarantool-patches@freelists.org>; Sun, 24 Jun 2018 16:42:57 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v4 5/6] sql: move Triggers to
 server
References: <cover.1529490955.git.kshcherbatov@tarantool.org>
 <cover.1529490955.git.kshcherbatov@tarantool.org>
 <8d28de228babb13b962c8ffed9399caf45586447.1529490955.git.kshcherbatov@tarantool.org>
 <4FD641D5-2133-4135-ADC6-72900826F458@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <255e0709-c2e9-0a51-e69c-6db54448e386@tarantool.org>
Date: Sun, 24 Jun 2018 23:41:11 +0300
MIME-Version: 1.0
In-Reply-To: <4FD641D5-2133-4135-ADC6-72900826F458@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Nikita Pettik <korablev@tarantool.org>, Kirill Shcherbatov <kshcherbatov@tarantool.org>


>> @@ -3252,6 +3303,88 @@ on_replace_dd_trigger(struct trigger * /* trigger */, void *event)
>> {
>> +		const char *space_opts =
>> +			tuple_field_with_type_xc(new_tuple,
>> +						 BOX_TRIGGER_FIELD_OPTS,
>> +						 MP_MAP);
> 
> Why do we still hold string of ‘CREATE TRIGGER’ statement as a map?
> AFAIU trigger can’t feature any functional elements except for mentioned one.

In SQL - can not, but when we will persist Lua trigger, the map contains: body,
after/before/instead, delete/insert/replace etc. So lets leave it be map.