From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C2C74441841
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 26 Mar 2020 18:46:57 +0300 (MSK)
References: <cover.1585093031.git.v.shpilevoy@tarantool.org>
 <761ca71e8b796a6fef356dffc4b4d31f575abb3c.1585093031.git.v.shpilevoy@tarantool.org>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <2517d6e1-0751-51ba-f5ed-ea064742d4e8@tarantool.org>
Date: Thu, 26 Mar 2020 18:46:55 +0300
MIME-Version: 1.0
In-Reply-To: <761ca71e8b796a6fef356dffc4b4d31f575abb3c.1585093031.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 vshard 1/2] storage: introduce
	upgrade strategy
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org

Hi! Thanks for changes. It was really unexpected for me that such 
modifications as were in previous version is prohibited.

LGTM. Except the fact that you store upgrade code in storage/init. IMO 
it should be encapsulated in a separate file.

On 25/03/2020 02:44, Vladislav Shpilevoy wrote:
> Since vshard creation it never needed any schema changes. Version
> of vshard schema was always '1', stored in _schema as
> 'oncevshard:storage:1', because it was created by
> box.once('vshard:storage:1').