From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 87251452566 for ; Tue, 5 Nov 2019 15:45:43 +0300 (MSK) From: Vladislav Shpilevoy References: Message-ID: <24ce061c-0fb2-fd25-01b3-a1bf98db1f7b@tarantool.org> Date: Tue, 5 Nov 2019 15:51:32 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 1/1] replication: use empty password by default List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org, kostja.osipov@gmail.com Also I forgot a description for the test. Here it is: (force pushed to the branch) ======================================================================== diff --git a/test/replication/gh-4605-empty-password.result b/test/replication/gh-4605-empty-password.result index 4cb2c37c1..defdfcfcd 100644 --- a/test/replication/gh-4605-empty-password.result +++ b/test/replication/gh-4605-empty-password.result @@ -2,6 +2,16 @@ test_run = require('test_run').new() | --- | ... + +-- +-- gh-4605: replication and netbox both use URI as a remote +-- resource identifier. If URI does not contain a password, netbox +-- assumes it is an empty string - ''. But replication's applier +-- wasn't assuming the same, and just didn't send a password at +-- all, when it was not specified in the URI. It led to a strange +-- error message and inconsistent behaviour. The test checks, that +-- replication now also uses an empty string password by default. + box.schema.user.create('test_user', {password = ''}) | --- | ... diff --git a/test/replication/gh-4605-empty-password.test.lua b/test/replication/gh-4605-empty-password.test.lua index 5472b66cd..f42a55f81 100644 --- a/test/replication/gh-4605-empty-password.test.lua +++ b/test/replication/gh-4605-empty-password.test.lua @@ -1,4 +1,14 @@ test_run = require('test_run').new() + +-- +-- gh-4605: replication and netbox both use URI as a remote +-- resource identifier. If URI does not contain a password, netbox +-- assumes it is an empty string - ''. But replication's applier +-- wasn't assuming the same, and just didn't send a password at +-- all, when it was not specified in the URI. It led to a strange +-- error message and inconsistent behaviour. The test checks, that +-- replication now also uses an empty string password by default. + box.schema.user.create('test_user', {password = ''}) box.schema.user.grant('test_user', 'replication') ========================================================================