From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 661B22C171 for ; Thu, 18 Apr 2019 14:34:39 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K7KhuDmukA3F for ; Thu, 18 Apr 2019 14:34:39 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 208C12C167 for ; Thu, 18 Apr 2019 14:34:39 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 2/4] swim: extract binary ip/port into a separate struct References: <86e84b69ecdd3ddd8e8abcb0f0b3818ba8d73d86.1555530516.git.v.shpilevoy@tarantool.org> <20190418151718.GD13022@chai> From: Vladislav Shpilevoy Message-ID: <24b491e7-3619-2f3f-eae9-743e491aafa1@tarantool.org> Date: Thu, 18 Apr 2019 21:34:36 +0300 MIME-Version: 1.0 In-Reply-To: <20190418151718.GD13022@chai> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Konstantin Osipov Pushed into the master. On 18/04/2019 18:17, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/04/18 09:03]: >> At this moment there are two binary structures in the SWIM >> protocol carrying an address: swim_member_passport and >> swim_meta_header_bin - one address in each. This code duplication >> was not formidable enough to stimulate creation of a separate >> address structure. >> >> But forthcoming indirect messages protocol extensions will add 2 >> new cases of encoding a binary address. It triggered this patch >> to reduce code duplication. >> > > OK to push. > > > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >