From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 022E12E73A
	for <tarantool-patches@freelists.org>; Sat, 11 May 2019 08:17:40 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 6xo0hufnj-lW for <tarantool-patches@freelists.org>;
	Sat, 11 May 2019 08:17:39 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A5CAB2A27D
	for <tarantool-patches@freelists.org>; Sat, 11 May 2019 08:17:39 -0400 (EDT)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: replace schema_find_id()
 by box_space_id_by_name()
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <20190507164102.GD10365@atlas>
Date: Sat, 11 May 2019 15:17:37 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <24C243E6-820D-489F-BC93-932F21CB75D4@tarantool.org>
References: <46e305e6bbce44d3a785963a58135d9efa425bdb.1556377851.git.imeevma@gmail.com>
 <642C2122-385A-4FBB-86DB-DB75E77081E6@tarantool.org>
 <20190507164102.GD10365@atlas>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Konstantin Osipov <kostja@tarantool.org>, Imeev Mergen <imeevma@tarantool.org>



> On 7 May 2019, at 19:41, Konstantin Osipov <kostja@tarantool.org> =
wrote:
>=20
> * n.pettik <korablev@tarantool.org> [19/05/07 19:21]:
>>=20
>>> +-- Ensure that the CREATE TRIGGER statement cannot be executed if
>>> +-- the user does not have enough rights. In this case, the user
>>> +-- does not have rights to read from _space.
>>> +--
>>> +box.execute([[CREATE TRIGGER r1 AFTER INSERT ON t1 FOR EACH ROW =
BEGIN SELECT 1; END; ]])
>>> +---
>>> +- error: Space 'T1' does not exist
>>=20
>> Such error looks a bit confusing IMHO. Could we tell the absence
>> of space from lack of rights?
>=20
> It's OK to produce a confusing error message for a user which has
> no access to a space. This message is just fine. We should just be
> consistent and not reveal that the space exists through the error
> message.

Ok, I don=E2=80=99t have any other objections, so patch LGTM.