From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EB88422969 for ; Tue, 10 Sep 2019 10:41:03 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NK8rPqtestdQ for ; Tue, 10 Sep 2019 10:41:03 -0400 (EDT) Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A55B722957 for ; Tue, 10 Sep 2019 10:41:03 -0400 (EDT) From: Georgy Kirichenko Subject: [tarantool-patches] Re: [PATCH] recovery: build secondary index in hot standby mode Date: Tue, 10 Sep 2019 17:40:54 +0300 Message-ID: <2483390.arBQlrxCkh@localhost> In-Reply-To: <20190814183144.17907-1-i.kosarev@tarantool.org> References: <20190814183144.17907-1-i.kosarev@tarantool.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart19125671.n15354q1BW"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Ilya Kosarev , i.kosarev@corp.mail.ru --nextPart19125671.n15354q1BW Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Wednesday, August 14, 2019 9:31:44 PM MSK Ilya Kosarev wrote: Hi, thanks for you patch! Please see my comments below >... > #include "gc.h" > +#include "wal.h" This breaks encapsulation and logic - a wal isn't the object the engine interacts with. > > /* sync snapshot every 16MB */ >... > > - if (!memtx->force_recovery) { > + if (!memtx->force_recovery && wal_dir_lock >= 0) { The same mistake, it isn't a memtx deal - is there any wal dir and was it locked or not. >... /* I pushed different solution onto your branch, please investigate it. Also there should be some tests I think. --nextPart19125671.n15354q1BW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEFZT35EtIMRTDS5hJnoTdFFzh6LUFAl13tfYACgkQnoTdFFzh 6LU9fwgApyDTtjeKdM/WLx9O/bdqQBykNWXrfzbI/TXv/kJyMEcIvjMBTbIqfHUN 0G3WL9ASmClILLuA9/SZniaIWmhkA1WPwEIrc9dp7XeCGrpsQAN48s7Ib2n/Gphx dcYl7fqJA2U4EEBWZGvlaD/iW62BJYALsBZF40VwjnQGL/mkACQUlnFPa+mGxYKR yAQkMb63AzpvW1SHO9K2en2X0sSQMy8ceGbbqgrA4KTKlArvJ11uLiOS36H+V0TM vIG+yFRbBwhfRSGWXHQHUkqzdHvGrtn1bc6z9derwyU5C+IposJI84QCDZgRM+xN Lxk4ukILIAEl7YqdB+rM3I3Zz0U4kg== =qAwL -----END PGP SIGNATURE----- --nextPart19125671.n15354q1BW--