From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 638906F3C5; Fri, 12 Mar 2021 23:01:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 638906F3C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615579274; bh=pl/M3thFcuVLb+7j/om1lrcoPJ7d66olSGGpSSJBvxk=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=d6M717MB8edU1xhGG0DOq/eLPx3pDJcHRbuXHxjSD8oSJPmJTqczNrw9fjaXwYs0b xUrzfXFskBClAMRZ3k1vaJpDKC9d3nzX8bXFw3neC9pSGX7ptMyaDRhGC18JIX6zCp uB8/gIzD5/iYCpRios1uOdJhmg0qhwnmWhqvaiAU= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A542D6F3C5 for ; Fri, 12 Mar 2021 23:01:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A542D6F3C5 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lKnyB-0002Ts-Ke; Fri, 12 Mar 2021 23:01:12 +0300 To: "Alexander V. Tikhonov" , Kirill Yukhin Date: Fri, 12 Mar 2021 23:01:05 +0300 Message-Id: <24774a7e599a4e60ca265b0feacc8e7b5af62fb2.1615576716.git.imun@tarantool.org> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69BD3280B63F8A20CED6D6453DBFA9511E900894C459B0CD1B9DDD6D25209DB4DE69C24C3357A3F0DFBBA84A4FAEA23A71BAE91743CFF4764B1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B2A9F8A35432468EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379B0255B5E5688AF88638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C11F5982A89E0728CE250870A1F2E76487FF3860F2058703CA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE74A95F4E53E8DCE969FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3A12191B5F2BB8629117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C22495B4C35AC65A386B3089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7CAD67A113071E75DA43847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E923155C0AF1600DCBC20B35F18F50A67673FEEF27D41596CE8E6E X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975C11F5982A89E0728CE250870A1F2E76487FF3860F2058703C9C2B6934AE262D3EE7EAB7254005DCEDAAE47F5F63E737721E0A4E2319210D9B64D260DF9561598F01A9E91200F654B02DA3D96DA0CEF5C48E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3441661D6226BE8C31704200B8E144C100E6A5E8D49FD20FC35D5113E10D2058576C115F5B841D6B931D7E09C32AA3244CF086AC1F9F48E74074E2AA573858A038A995755A1445935E927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQNwI24iyQ+pEzuieNUVMsQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822054D9D3F78E2D56568AD9D03CA2D998BA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: [Tarantool-patches] [PATCH] asan: suppress all LSAN warnings related to LuaJIT X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" After porting LuaJIT build system to CMake in commit 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust LuaJIT build system'), its build options are not fully maintained in Tarantool. E.g. several compile flags, such as -fomit-frame-pointer, are set within LuaJIT CMake machinery and there is no way to tweak them outside. As a result ASAN + LSAN build in Tarantool CI[1] reports new leaks related to LuaJIT runtime, but there is none of them actually (no source code changes are made in scope of the applied patchset). Hence it was decided to consider all LuaJIT related warnings as false positives for now and suppress them until #5878 is resolved. [1]: https://github.com/tarantool/tarantool/runs/1999839396 Follows up #4862 Relates to #5878 Signed-off-by: Igor Munkin --- This is a temporary solution, until #5878 is resolved. BTW, it looks like a ASAN/LSAN problem since, running it with fast_unwind_on_malloc=0 doesn't make CI green and otherwise I have no idea why -fno-omit-frame-pointer is obligatory for sanitizers (I found not a single word in Google sanitizers docs regarding it). Though there is no problems on the stable branches other than 1.10, I believe this patch should be applied to all branches containing 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust LuaJIT build system') to reduce the chance of unexpected CI breakage either on working or on stable branch. Issues: * https://github.com/tarantool/tarantool/issues/4862 * https://github.com/tarantool/tarantool/issues/5878 Branches: one with the patch and another providing CI is green on 1.10 * https://github.com/tarantool/tarantool/tree/imun/suppress-asan-for-luajit * https://github.com/tarantool/tarantool/tree/imun/suppress-asan-for-luajit-1.10 asan/lsan.supp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/asan/lsan.supp b/asan/lsan.supp index e3b62e653..198df89c3 100644 --- a/asan/lsan.supp +++ b/asan/lsan.supp @@ -24,9 +24,12 @@ leak:Curl_resolver_init # source: /usr/lib/x86_64-linux-gnu/gconv/UTF-16.so leak:gconv_init -# test: box*/ +# XXX: All warnings reported for LuaJIT runtime are considered +# false positive until sanitizers support is not introduced in +# LuaJIT. See the issue below for more info. +# https://github.com/tarantool/tarantool/issues/5878 # source: third_party/luajit -leak:lj_BC_FUNCC +leak:lj_* # test: box/access.test.lua # test: box/access_bin.test.lua -- 2.25.0