From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 45E7342EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  3 Jul 2020 02:36:16 +0300 (MSK)
References: <cover.1593472477.git.v.shpilevoy@tarantool.org>
 <9ece5bf917856b1b86e6309504e95f55b7c2c6ca.1593472477.git.v.shpilevoy@tarantool.org>
 <d7e757f8-d055-f5c2-9754-5896e1069a1d@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <246afc62-ddad-63f0-739e-c5d2acfad50b@tarantool.org>
Date: Fri, 3 Jul 2020 01:36:14 +0200
MIME-Version: 1.0
In-Reply-To: <d7e757f8-d055-f5c2-9754-5896e1069a1d@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH v2 02/19] replication: introduce
 replication_synchro_* cfg options
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the review!

>> diff --git a/src/box/box.cc b/src/box/box.cc
>> index 871b0d976..0821ea0a3 100644
>> --- a/src/box/box.cc
>> +++ b/src/box/box.cc
>> @@ -476,6 +476,31 @@ box_check_replication_sync_lag(void)
>>       return lag;
>>   }
>>   +static int
>> +box_check_replication_synchro_quorum(void)
>> +{
>> +    int quorum = cfg_geti("replication_synchro_quorum");
>> +    if (quorum <= 0 || quorum > VCLOCK_MAX) {
> 
> It should be `quorum >= VCLOCK_MAX`, because you can't have VCLOCK_MAX (32)
> 
> instances in a cluster, only 31. Id 0 is used by anonymous replicas.

Indeed, done and squashed.