From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6E7602569B
	for <tarantool-patches@freelists.org>; Tue, 29 Jan 2019 08:14:54 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 5WYyJv4vAm1g for <tarantool-patches@freelists.org>;
	Tue, 29 Jan 2019 08:12:14 -0500 (EST)
Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 194B725223
	for <tarantool-patches@freelists.org>; Tue, 29 Jan 2019 08:12:14 -0500 (EST)
Subject: [tarantool-patches] Re: [PATCH v2] sql: prohibit type_def
 keywords in the VALUES statement
References: <20190129105518.22723-1-szudin@tarantool.org>
 <AE8DB4D0-99D0-423A-BDCE-BED27192229D@tarantool.org>
From: Stanislav Zudin <szudin@tarantool.org>
Message-ID: <244066f3-66f0-1c7a-fdf3-3f5a06981208@tarantool.org>
Date: Tue, 29 Jan 2019 16:12:12 +0300
MIME-Version: 1.0
In-Reply-To: <AE8DB4D0-99D0-423A-BDCE-BED27192229D@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, "n.pettik" <korablev@tarantool.org>

On 29.01.2019 15:31, n.pettik wrote:
>> The parser didn't distinguish the type definition keywords from values.
> Why did you change your commit message? It was good except for
> that it was not formatted. Lets return it back, format (align text border
> to 72 chars) and then patch will be entirely OK.
>
>> Closes #3888
>> ---
>> Branch: https://github.com/tarantool/tarantool/tree/sz/gh-3888-values-blob-assert
>> Issue: https://github.com/tarantool/tarantool/issues/3888
>> —
> Don’t put this delimiter again (next time), it should appear only once.
Fixed.