From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E3BEF24E2D
	for <tarantool-patches@freelists.org>; Fri, 11 May 2018 11:18:31 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Yg39NB5TmiGb for <tarantool-patches@freelists.org>;
	Fri, 11 May 2018 11:18:31 -0400 (EDT)
Received: from forward5p.cmail.yandex.net (forward5p.cmail.yandex.net [77.88.31.20])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DA874208A5
	for <tarantool-patches@freelists.org>; Fri, 11 May 2018 11:18:30 -0400 (EDT)
From: roman.habibov1@yandex.ru
In-Reply-To: <C3D1B7D5-6BC1-4713-A9EA-76C76CFEA078@tarantool.org>
References: <aae0bec697872f421cf229b02ae3fc5f93a2b24e.1525474833.git.roman.habibov1@yandex.ru>
	 <BB1D3105-6F9A-445C-9675-F9A172F79737@tarantool.org>
	 <2050311525824390@web59j.yandex.ru>
	 <225ED31B-14F7-4BF1-9383-2100722DFEF2@tarantool.org>
	 <6369401525886435@web18j.yandex.ru> <C3D1B7D5-6BC1-4713-A9EA-76C76CFEA078@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: added tests for TEMP and TEMPORARY clauses
MIME-Version: 1.0
Message-Id: <2421251526051907@web18j.yandex.ru>
Date: Fri, 11 May 2018 18:18:27 +0300
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>, "tarantool-patches@freelists.org" <tarantool-patches@freelists.org>



>>>  Please, read guidelines carefully.
>>>
>>>>  sql: Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE
>>>
>>>  According to our docs:
>>>  — 2. Try to limit the subject line to 50 characters or so.
>>>  — 3. Start the subject line with a capital letter unless it prefixed with a subsystem name and semicolon…
>>  Sorry. I fixed that.
>
> No, you didn’t. Read it again. I see old violations on your branch.
But now?

>> There is exeptions, when these clauses are used.
>
> Typo: ’there are’. Use some spell-checker or whatever.
> Rephrase whole sentence: it seems to be misleading.
Rephrased.

>>>  I would also add tests (or just rewrite yours) which check that complete CREATE TABLE statement doesn’t support TEMP clause:
>>>
>>>  CREATE TEMP TABLE t1(…);
>>>
>>>  CREATE TEMPORARY TABLE t1(…);
>>  + CREATE TEMP TABLE t1();
>>  + CREATE TEMPORARY TABLE t1();
>
> Cmon, use complete form of CREATE TABLE statement.
> You can’t create table with no columns.
diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua
index 84eb884..f0a1cbc 100755
--- a/test/sql-tap/table.test.lua
+++ b/test/sql-tap/table.test.lua
@@ -617,7 +617,7 @@ test:do_execsql2_test(
 test:do_catchsql_test(
 	"temp",
 	[[
-		CREATE TEMP TABLE t1();
+		CREATE TEMP TABLE t1(col1 int, col2 int);
 	]], {
 	-- <temp>
 	1, "near \"TEMP\": syntax error"
@@ -627,7 +627,7 @@ test:do_catchsql_test(
 test:do_catchsql_test(
 	"temporary",
 	[[
-		CREATE TEMPORARY TABLE t1();
+		CREATE TEMPORARY TABLE t1(col1 int, col2 int);
 	]], {
 	-- <temporary>
 	1, "near \"TEMPORARY\": syntax error"