From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D7299245C1 for ; Mon, 23 Jul 2018 09:17:21 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qrXEFtWmsmkH for ; Mon, 23 Jul 2018 09:17:21 -0400 (EDT) Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 276D42017F for ; Mon, 23 Jul 2018 09:17:21 -0400 (EDT) From: Georgy Kirichenko Subject: [tarantool-patches] Re: [PATCH] add FindICONV and iconv wrapper Date: Mon, 23 Jul 2018 16:17:10 +0300 Message-ID: <2411664.Jxh9JcPWzN@localhost> In-Reply-To: <20180720165052.8631-1-k.belyavskiy@tarantool.org> References: <20180720165052.8631-1-k.belyavskiy@tarantool.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3945296.H80zJLzWn7"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Konstantin Belyavskiy Cc: tarantool-patches@freelists.org --nextPart3945296.H80zJLzWn7 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Mostly good, but see on my comments bellow On Friday, July 20, 2018 7:50:52 PM MSK Konstantin Belyavskiy wrote: > Fixing build under FreeBSD: > +# - Find the readline include files and libraries > +# - Include finding of termcap or curses Wrong comment > +iconv_wrap_open > +iconv_wrap_close > +iconv_wrap I would be like if you renamed this using pattern tnt_ > exception_get_string > exception_get_int > > lua/errno.c > + lua/iconv_wrap.c I would be like if you used name like tnt_iconv.c > lua/socket.c > lua/pickle.c > lua/fio.c > diff --git a/src/lua/iconv_wrap.h b/src/lua/iconv_wrap.h > new file mode 100644 > index 000000000..03aee40e4 > --- /dev/null > +++ b/src/lua/iconv_wrap.h I am do not really sure we need this file --nextPart3945296.H80zJLzWn7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEFZT35EtIMRTDS5hJnoTdFFzh6LUFAltV1VYACgkQnoTdFFzh 6LVG8wgAkaf5vvTP3VwF8gcMBP6iR9OIlqiYh/V/TZR7ch6VhA/HXZDsJL2djUaW HhXlXIyEux03n0j9sRJhz2Lx6uk3N5Wnms0mzc8+Zluym8QB+fFF5v4MUOvBXOH0 MfvZPXC9UZEZ2tr0mNFQLUWvAcQw6MUm5J4RfpIKUC5s0ff8XEJyP/yPdOWX4JWB nEKgHqXrkR1/3OgDSwNpvxU00jt1g/tw3M9gDrv8YpDPM5F51wBa1OUrnlLx7L/F U1mP5/yIbW7QSpVyP5RqVBYHuF0v/QCZVrEd9Ae23/AxTWWuqpBTzBzn1oAdV/TB CRHRPTwhtLARGVJQj6O/RKG5KZuYlw== =cSkM -----END PGP SIGNATURE----- --nextPart3945296.H80zJLzWn7--