From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D2A2346970F for ; Fri, 29 Nov 2019 01:55:39 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <23b58aee-f8f7-77d8-347a-8ba0215028dc@tarantool.org> Date: Thu, 28 Nov 2019 23:55:36 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 0/6] sql: extend response metadata List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik , tarantool-patches@dev.tarantool.org Please, add a docbot request to the final commit. It should include binary protocol change description. On 27/11/2019 13:15, Nikita Pettik wrote: > Branch: https://github.com/tarantool/tarantool/tree/np/gh-4407-extend-sql-metadata > Issue: https://github.com/tarantool/tarantool/issues/4407 > > This patch-set extends metadata with collation, nullability, > autoincrement and alias properties of resulting set columns. > Quite straightforward implementation. > > Nikita Pettik (6): > sql: refactor resulting set metadata > sql: fix possible null dereference in sql_expr_coll() > sql: extend result set with collation > sql: extend result set with nullability > sql: extend result set with autoincrement > sql: extend result set with alias > > src/box/execute.c | 65 +++- > src/box/iproto_constants.h | 4 + > src/box/lua/execute.c | 22 +- > src/box/lua/net_box.c | 33 +- > src/box/sql/delete.c | 6 +- > src/box/sql/expr.c | 3 +- > src/box/sql/insert.c | 5 +- > src/box/sql/legacy.c | 2 +- > src/box/sql/pragma.c | 14 +- > src/box/sql/prepare.c | 9 +- > src/box/sql/select.c | 95 +++-- > src/box/sql/sqlInt.h | 12 + > src/box/sql/update.c | 6 +- > src/box/sql/vdbe.h | 41 ++- > src/box/sql/vdbeInt.h | 17 +- > src/box/sql/vdbeapi.c | 103 +++--- > src/box/sql/vdbeaux.c | 126 +++++-- > test/box/sql-update-with-nested-select.result | 5 +- > test/sql-tap/badutf1.test.lua | 46 +-- > test/sql-tap/colname.test.lua | 16 +- > test/sql-tap/lua/sqltester.lua | 29 ++ > test/sql-tap/select1.test.lua | 18 +- > test/sql-tap/select4.test.lua | 4 +- > test/sql-tap/view.test.lua | 2 +- > test/sql/bind.result | 15 +- > test/sql/boolean.result | 431 ++++++++++++++--------- > test/sql/check-clear-ephemeral.result | 5 +- > test/sql/collation.result | 241 ++++++++----- > test/sql/gh-3199-no-mem-leaks.result | 120 ++++--- > test/sql/gh2141-delete-trigger-drop-table.result | 20 +- > test/sql/gh2251-multiple-update.result | 10 +- > test/sql/iproto.result | 110 +++--- > test/sql/misc.result | 25 +- > test/sql/on-conflict.result | 20 +- > test/sql/persistency.result | 190 ++++++---- > test/sql/row-count.result | 25 +- > test/sql/sql-debug.result | 15 +- > test/sql/transition.result | 190 ++++++---- > test/sql/types.result | 105 +++--- > test/sql/update-with-nested-select.result | 5 +- > 40 files changed, 1376 insertions(+), 834 deletions(-) >