From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1C69A6EC5B; Sat, 10 Apr 2021 18:03:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1C69A6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618067019; bh=J0WQLKDaNcuwlNPk22AJmTFwEYXhz3PtffWut8oVQFg=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ETCxEy2XWzyQ7lr8lg7ACqsGWVv1pYb0n5KdFBGhvdX9V3RAR7y4Jo1sLiu8Gap/1 fZU50zAIU2mNJhHjxtD7nXkU1hMkp3UNnGQjHJ6whNEBFie/m5arjHXXvekWRnjvJW ZwiefSjyg660zw9AZoq4wfDZklUn69ElqkCYLSeU= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B358A6EC5B for ; Sat, 10 Apr 2021 18:03:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B358A6EC5B Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1lVF96-0005F7-2p; Sat, 10 Apr 2021 18:03:36 +0300 To: Vladislav Shpilevoy , alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <0feec24c50d302255a300e27678448577f30540b.1617888916.git.sergepetrenko@tarantool.org> <3b023576-0a64-9347-e2cb-f355d6bd9e94@tarantool.org> Message-ID: <236018bf-5447-7909-25e7-d93bf667a9b0@tarantool.org> Date: Sat, 10 Apr 2021 18:03:35 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <3b023576-0a64-9347-e2cb-f355d6bd9e94@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480257C85EA0BB7A95D0F00AE41BB9A5343182A05F538085040B7F1D937175FB0E3264DA94B3AEBE2086FE9DF14AD079DFC65E721877AD2717D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CB5C87C4C9A74E8BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370CE4B4B08BC34B6C8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2F288AEEB0986BFF9F1CA7C88B06B3EBA39A77D2A56A56FF9D2E47CDBA5A96583C09775C1D3CA48CFED8438A78DFE0A9E117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7BBAB42A99ED9B9F9D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C0E0F2381F647739FAB3661434B16C20AC78D18283394535A9E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6D635BA3ABDB36C18089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A575348CA78031D448F1B2373597A82655941A5604FFAE0D8DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34023CA4E4726A7D6C89849DC4C10FF87A2744740A06A9DCBC7E86D9AFEFCA697067C1019B8246032D1D7E09C32AA3244C7270976D29A3DD16108388A4F6B27A968894E9C85370243EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqcJA+pXcDumuxb2CPm6vkw== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F8A306FCACB9EBAE0DD973BF6419F6E4C9B8DD0191BD683AA6424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 3/5] feedback_daemon: send feedback on server start X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 10.04.2021 00:53, Vladislav Shpilevoy пишет: > Hi! Thanks for the patchset! Thanks for the review! > > On 08.04.2021 15:38, Serge Petrenko via Tarantool-patches wrote: >> Send the first report as soon as instance's initial configuration >> finishes. >> >> Part of #5750 >> --- >> src/box/lua/feedback_daemon.lua | 10 ++++++++++ >> src/box/lua/load_cfg.lua | 34 ++++++++++++++++++++++----------- >> 2 files changed, 33 insertions(+), 11 deletions(-) >> >> diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua >> index d00eedf39..43bbc1fa2 100644 >> --- a/src/box/lua/feedback_daemon.lua >> +++ b/src/box/lua/feedback_daemon.lua >> @@ -323,6 +323,12 @@ local function fill_in_feedback(feedback) >> return feedback >> end >> >> +-- fixme: remove this hack. >> +-- It's here to prevent too early feedback sending. >> +-- This leads to problems with thread sanitization after fork() on Mac OS. >> +-- Google objc_initializeAfterForkError for details. >> +local is_first_send = true > Have you tried this? > https://stackoverflow.com/questions/50168647/multiprocessing-causes-python-to-crash-and-gives-an-error-may-have-been-in-progr Yes, I have. I was worried there are some test failures in CI caused by curl's too early initialization, which wouldn't be solved by setting that env variable. Actually there is such a problem in CI. I've tried a patch with sleeping only on Mac, and release_asan_clang job has a lot of failed tests, each reporting a leak from CRYPTO_memdup/CRYPTO_strdup/CRYPTO_strndup: https://github.com/tarantool/tarantool/runs/2313054777?check_suite_focus=true Moreover, I'm afraid that setting that env variable we may miss any further alerts from Mac's thread/fork sanitizer. Long story short, let's leave this hack as is for now. Here's the patch I was trying to apply: diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua index 43bbc1fa2..cc4e24559 100644 --- a/src/box/lua/feedback_daemon.lua +++ b/src/box/lua/feedback_daemon.lua @@ -327,7 +327,7 @@ end  -- It's here to prevent too early feedback sending.  -- This leads to problems with thread sanitization after fork() on Mac OS.  -- Google objc_initializeAfterForkError for details. -local is_first_send = true +local is_first_send = jit.os == 'OSX' and true or nil  local function feedback_loop(self)      fiber.name(PREFIX, { truncate = true }) > > We could add it to the CI jobs so the env variable would be > set. And set it manually on our own machines. > > You can also use jit.os to start it without a delay on > non-Mac machines. On Mac jit.os == 'OSX'. I see we use it > in some places, so it looks legal and working. -- Serge Petrenko