From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 484362EF47 for ; Mon, 3 Jun 2019 04:07:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nM_Enly7EXsL for ; Mon, 3 Jun 2019 04:07:13 -0400 (EDT) Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 05B85277AE for ; Mon, 3 Jun 2019 04:07:12 -0400 (EDT) From: =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= Subject: [tarantool-patches] Re: [PATCH v2 5/8] Commit engine before all triggers Date: Mon, 03 Jun 2019 11:07:05 +0300 Message-ID: <2320037.H8aGZzUreG@home.lan> In-Reply-To: <20190531193212.GD6141@atlas> References: <20190531193212.GD6141@atlas> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1858559.7ROQxYSHbs"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Konstantin Osipov Cc: tarantool-patches@freelists.org --nextPart1858559.7ROQxYSHbs Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday, May 31, 2019 10:32:12 PM MSK Konstantin Osipov wrote: > * Georgy Kirichenko [19/05/23 11:47]: > > --- > > > > src/box/txn.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > Why do you need this change? > > Since on_commit() triggers are not allowed to fail, this is > harmless. on_commit trigger could yield and break engine->commit order. However, I doesn't affect us right now (at least I don't have proofs), and this patch could be eliminated. --nextPart1858559.7ROQxYSHbs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEFB+nbqWGnp59Rk9ZFSyY70x8X3sFAlz01SkACgkQFSyY70x8 X3sd8gf+KoyGI639CkYhEIh7mZlWR0gr8NqPXn6XAs871OI5+/ghGAP6YJfqI74h Ziu0HXEejJIQDBe8Y/vj/C8Z2Al1k87oON8tov7TwoZSisPjQYM3OQQFEgmE0rKq 9pqXNpEGEhrrwtwfImvVip92avXLBJW1nYvihdANpr2cNEd8N8CXpjCrbDZOpd9e pq7lS+lBc6V5N6ZwpUJMvCLsFlQ/3KplWj8TH85es5ZjerY3rWQKNV54zN/Z9sc5 ERI5rPiNYRwkSweVuKgn1CE6dHlcg12fXF6XIsUyCLXaZYlO19Vt7FrJRPN55cbX NKAdDYBFu0pYkToziMwFpK90XB2/mw== =ODec -----END PGP SIGNATURE----- --nextPart1858559.7ROQxYSHbs--