From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7A34C42EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 16 Jun 2020 02:15:10 +0300 (MSK)
References: <cover.1592151487.git.v.shpilevoy@tarantool.org>
 <20200615140142.jgeryiqpfnhdxs55@tkn_work_nb>
 <a2f7e99b-b264-c304-47cd-42e625261974@tarantool.org>
 <20200615230430.d63w2nc5olmggkxw@tkn_work_nb>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <230d46c5-2ce7-5887-f6ab-4b4bdbc9171c@tarantool.org>
Date: Tue, 16 Jun 2020 01:15:08 +0200
MIME-Version: 1.0
In-Reply-To: <20200615230430.d63w2nc5olmggkxw@tkn_work_nb>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 0/2] ASAN build
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 16/06/2020 01:04, Alexander Turenko wrote:
> On Tue, Jun 16, 2020 at 12:21:13AM +0200, Vladislav Shpilevoy wrote:
>> Hi!
>>
>> On 15/06/2020 16:01, Alexander Turenko wrote:
>>> LGTM except broken coverage reporting:
>>>
>>> https://travis-ci.org/github/tarantool/tarantool/jobs/698246927
>>>
>>> It looks quite similar to
>>> https://github.com/tarantool/tarantool/commit/415c05868f95b45a56904d5aa581358aced05efe
>>>
>>> Maybe we should add '-o ${CMAKE_BINARY_DIR}/src/box/sql/parse.c' to
>>> lemon call to write absolute path in #line directives, which may help to
>>> avoid ambiguity.
>>
>> Thanks for noticing and for the proposed fix. I did this:
>>
>> -    COMMAND ${EXT_BIN_DIR}/lemon -T${EXT_SRC_DIR}/lempar.c ${SQL_SRC_DIR}/parse.y
>> +    COMMAND ${EXT_BIN_DIR}/lemon -T${EXT_SRC_DIR}/lempar.c -o${SQL_BIN_DIR}/parse ${SQL_SRC_DIR}/parse.y
> 
> Nit: I would use `-o${SQL_BIN_DIR}/parse.c` with explicit `.c` suffix.
> The effect is the same, but the command line looks more natural. Up to
> you.

Changed to parse.c.