From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C7D0926EA3 for ; Fri, 17 Aug 2018 08:40:44 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TpefqVlI7m0z for ; Fri, 17 Aug 2018 08:40:44 -0400 (EDT) Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 86C6C217A0 for ; Fri, 17 Aug 2018 08:40:44 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: remove struct Enc References: <792834dabd4287aeb213202581de02b23a4c4557.1534508548.git.kshcherbatov@tarantool.org> From: Vladislav Shpilevoy Message-ID: <22d959eb-5c4e-fb12-f7de-cf10a237f0dd@tarantool.org> Date: Fri, 17 Aug 2018 15:40:42 +0300 MIME-Version: 1.0 In-Reply-To: <792834dabd4287aeb213202581de02b23a4c4557.1534508548.git.kshcherbatov@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Kirill Shcherbatov Cc: korablev@tarantool.org Hi! Please, do not use any Lua things in SQL. You should not even include this: #include "lua/msgpack.h". On 17/08/2018 15:24, Kirill Shcherbatov wrote: > We shouldn't use legacy Enc structure in SQL as we have > featured class mpstream in tarantool core. With this path > all allocations temporally commited with mpstream initialized > on region and then duplicated in dynamic persistent memory via > sqlite3DbMallocRaw. > > Closes #3545. > --- > Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3545-remove-enc-struct > Issue: https://github.com/tarantool/tarantool/issues/3545 >