From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A6A4016EC060; Fri, 2 Jan 2026 19:01:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A6A4016EC060 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1767369712; bh=OFKIYabNZVOL9iB0s7g18Xa5qOkhGKJm9PSUJ6T/tDU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hv000iKfqu+LISazxH5iiIYbu3S+N4oWGKYahpyuCHcP80HAYD75yY7HDU4GmHWFc fCs8ue+wTsdUC2dJtvS0PsFsNdYGvZGakLp8Yn+F2rfAKup0gCxoPU+fkB7jXJHqKF NV7NHGLwjQv8kOBQS8FYPnYpXYncK+aKZKXnM1h8= Received: from send105.i.mail.ru (send105.i.mail.ru [89.221.237.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B12C316EC052 for ; Fri, 2 Jan 2026 19:01:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B12C316EC052 Received: by exim-smtp-7b4fb89df9-f2bg5 with esmtpa (envelope-from ) id 1vbhb1-000000009vy-3GgM; Fri, 02 Jan 2026 19:01:50 +0300 Content-Type: multipart/alternative; boundary="------------HmiNz1G5w7vo6U9LvrpaGLOV" Message-ID: <22a540f3-9fe4-470f-b3d5-263fada6b201@tarantool.org> Date: Fri, 2 Jan 2026 19:01:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <51be3232be0be26763b2f3cd48d3a44eec0e5516.1766738771.git.skaplun@tarantool.org> In-Reply-To: <51be3232be0be26763b2f3cd48d3a44eec0e5516.1766738771.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD136B1DE29D0A14186819F7335A1BEA2E182A05F538085040B06FACD02F5C61013DE06ABAFEAF6705E46AE353898940A27ACA87A2557ADB15ACCB5262BB501CA2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7461BBD5973015A08EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375AC38C7EC4509C8B8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B29C5014D7394688DA2E070BE324C7D3C47A48D40BDF087D44F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C0FEA73F50E9734B707B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F9647ADFADE5905B1FCB1554B277F7060B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9149C560DC76099D75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5E6B6412B5C0DC1DD5002B1117B3ED69614FDE60DC371D1AD1BDDAE3D1EA49BEA823CB91A9FED034534781492E4B8EEAD220496FFA5CD4785BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6596272A785268DD08F550A3ACA65067FB81F6098B9E234AEF45B2E59F7EE37D3C53717FE049F2BEA5BB8341EE9D5BE9A0AD518D7D7496BFD84F43134626574F47EB0F044C24E09005C8CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVTZJppT4ZVHRoyPhFoJ1Ghk= X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458DAF6E0B1D273B171AA70CB78A12CDBB55347560E31C27D223539925954DC51AE645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 30/41] perf: adjust scimark-lu in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------HmiNz1G5w7vo6U9LvrpaGLOV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM Sergey On 12/26/25 12:18, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > > Checks are omitted since they were not present in the original suite, > plus the precise result value depends on the input parameter. > --- > perf/LuaJIT-benches/scimark-lu.lua | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/perf/LuaJIT-benches/scimark-lu.lua b/perf/LuaJIT-benches/scimark-lu.lua > index 7636d994..4f521e0b 100644 > --- a/perf/LuaJIT-benches/scimark-lu.lua > +++ b/perf/LuaJIT-benches/scimark-lu.lua > @@ -1 +1,19 @@ > -require("scimark_lib").LU(100)(tonumber(arg and arg[1]) or 5000) > +local bench = require("bench").new(arg) > + > +local cycles = tonumber(arg and arg[1]) or 5000 Why this option is absent in usage? > + > +local benchmark > +benchmark = { > + name = "scimark_lu", > + -- XXX: The description of tests for the function is too > + -- inconvenient. > + skip_check = true, > + payload = function() > + local flops = require("scimark_lib").LU(100)(cycles) > + benchmark.items = flops > + end, > +} > + > +bench:add(benchmark) > + > +bench:run_and_report() --------------HmiNz1G5w7vo6U9LvrpaGLOV Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM

Sergey

On 12/26/25 12:18, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.

Checks are omitted since they were not present in the original suite,
plus the precise result value depends on the input parameter.
---
 perf/LuaJIT-benches/scimark-lu.lua | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/perf/LuaJIT-benches/scimark-lu.lua b/perf/LuaJIT-benches/scimark-lu.lua
index 7636d994..4f521e0b 100644
--- a/perf/LuaJIT-benches/scimark-lu.lua
+++ b/perf/LuaJIT-benches/scimark-lu.lua
@@ -1 +1,19 @@
-require("scimark_lib").LU(100)(tonumber(arg and arg[1]) or 5000)
+local bench = require("bench").new(arg)
+
+local cycles = tonumber(arg and arg[1]) or 5000
Why this option is absent in usage? 
+
+local benchmark
+benchmark = {
+  name = "scimark_lu",
+  -- XXX: The description of tests for the function is too
+  -- inconvenient.
+  skip_check = true,
+  payload = function()
+    local flops = require("scimark_lib").LU(100)(cycles)
+    benchmark.items = flops
+  end,
+}
+
+bench:add(benchmark)
+
+bench:run_and_report()
--------------HmiNz1G5w7vo6U9LvrpaGLOV--