From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id F1D382CC33 for ; Tue, 27 Mar 2018 07:35:10 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 69GAUgNDET46 for ; Tue, 27 Mar 2018 07:35:10 -0400 (EDT) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id AECE82CC32 for ; Tue, 27 Mar 2018 07:35:10 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: [tarantool-patches] Re: [PATCH v2 0/2] Introduce 'view' space option From: "v.shpilevoy@tarantool.org" In-Reply-To: Date: Tue, 27 Mar 2018 14:35:05 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <22FC98A6-7F8A-40BB-B738-8BFBD6E30815@tarantool.org> References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: tarantool-patches@freelist.org, Nikita Pettik LGTM. > 27 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2018 =D0=B3., =D0=B2 2:03, Nikita = Pettik =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB= (=D0=B0): >=20 > Branch: = https://github.com/tarantool/tarantool/tree/np/gh-3268-introduce-view > Issue: https://github.com/tarantool/tarantool/issues/3268 = =20 >=20 > Changelog: = =20 > - Added tests to check that view can't be created via Lua = 'create_space' > function, and to check that view can be created by direct insertion > to _space. = =20 > - Implemented SQL follow-up patch to remove TF_View flag and to fetch > 'view' property from SQL. =20 >=20 > Nikita Pettik (2): > Introduce 'view' space option > sql: use 'view' opts from space >=20 > src/box/alter.cc | 7 ++++ > src/box/errcode.h | 3 +- > src/box/space_def.c | 7 ++++ > src/box/space_def.h | 6 +++ > src/box/sql.c | 9 +++- > src/box/sql/alter.c | 4 +- > src/box/sql/build.c | 27 ++++++++---- > src/box/sql/delete.c | 2 +- > src/box/sql/fkey.c | 3 +- > src/box/sql/insert.c | 10 +++-- > src/box/sql/parse.c | 4 +- > src/box/sql/parse.y | 5 +-- > src/box/sql/select.c | 4 +- > src/box/sql/sqliteInt.h | 5 ++- > src/box/sql/trigger.c | 4 +- > src/box/sql/update.c | 2 +- > src/box/sql/vdbeaux.c | 2 +- > src/box/sql/where.c | 3 +- > test/box/misc.result | 1 + > test/sql/transition.result | 7 ---- > test/sql/transition.test.lua | 4 -- > test/sql/view.result | 98 = ++++++++++++++++++++++++++++++++++++++++++++ > test/sql/view.test.lua | 46 +++++++++++++++++++++ > 23 files changed, 220 insertions(+), 43 deletions(-) > create mode 100644 test/sql/view.result > create mode 100644 test/sql/view.test.lua >=20 > --=20 > 2.15.1 >=20 >=20