From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 660964696C3
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 23 Mar 2020 09:42:13 +0300 (MSK)
References: <cover.1584817081.git.v.shpilevoy@tarantool.org>
 <f68117750f221d0fe67134bd5058ac3c92db5be7.1584817081.git.v.shpilevoy@tarantool.org>
 <1f571d45-179d-1b72-941d-3de21c2e8f11@tarantool.org>
 <4a6edd2a-7173-706c-0622-a805b152dc70@tarantool.org>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <228c747e-13b4-10a1-7626-9ee4ad99567a@tarantool.org>
Date: Mon, 23 Mar 2020 09:42:11 +0300
MIME-Version: 1.0
In-Reply-To: <4a6edd2a-7173-706c-0622-a805b152dc70@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH vshard 2/2] storage: introduce
	vshard.storage._call()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org

Thanks for your answers. Seems I've missed one comment. But LGTM in general.

On 22/03/2020 22:13, Vladislav Shpilevoy wrote:
>>> +
>>> +local function service_call(...)
>>> +    local service_name = select(1, ...)
>>> +    return service_call_api[service_name](select(2, ...))
>>> +end
>>

What's about a following diff?
============
diff --git a/vshard/storage/init.lua b/vshard/storage/init.lua
index 6aa5d6a..3653914 100644
--- a/vshard/storage/init.lua
+++ b/vshard/storage/init.lua
@@ -2203,9 +2203,8 @@ service_call_api = setmetatable({
      return res
  end})

-local function service_call(...)
-    local service_name = select(1, ...)
-    return service_call_api[service_name](select(2, ...))
+local function service_call(service_name, ...)
+    return service_call_api[service_name](...)
  end
============