From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7C3316EC5D; Mon, 5 Apr 2021 19:11:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7C3316EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617639070; bh=ylI3/+Eogu2GpatsYKtZSnltsaBuEHjy5a+GaQviDMQ=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=iJ9hba3oxQL+q4nWYmaeGLsUAnnm4QBCv4APzFv81839CZ9UtBGNPzrU4PwMz7FMI w2IFbWXk9IQhZlJcCFTLELn8P8uq8pPsM+3iUBxGizEt0qhHx4WJuHhFotWxfV0MXD qoANr4cZ2fphdjK+toEzi5CfNoEqGMt0wlUdJKH0= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7D2156EC5D for ; Mon, 5 Apr 2021 19:11:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7D2156EC5D Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lTRoh-0004Z6-LK; Mon, 05 Apr 2021 19:11:08 +0300 To: Serge Petrenko , alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <53f906760f240ea0f381fd693000139e8d5e5c8c.1617375300.git.sergepetrenko@tarantool.org> Message-ID: <226e5b15-049b-38ec-c03a-3af26989fe55@tarantool.org> Date: Mon, 5 Apr 2021 18:11:05 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294DD38BE31D7797EF84C856624A09E4809182A05F53808504068569BCBD0F7078F2473B351D3FF6864A81F5BA024AA73F04EB9AD12F6A39DB3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FBCED7D376B82B5EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B24541F05F0BFC9F8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C16EE06F5A270FE6AC99C2954156766CCE01BCC26B9954F63A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7820CF4CC0E318EFB9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C311471C67CF6D96D5117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637553F28B1F14F2446EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5512371FFBC6D259DB000F6BC2A5C63F56DDDD36C0EE23F29D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AB80C45F81B80D63DC91DBD0610E693195D853C59CA3091A45245ED595DA43C4EFAD9C923D5ACD7C1D7E09C32AA3244C6F4CB136F2AFEBD7C7A50E2310DB839755E75C8D0ED9F6EEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojM00ve/f+0olSP79QeTVY3w== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822091670EC892370B0100235E92FE7C7963841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/4] feedback_daemon: send feedback on server start X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 05.04.2021 16:05, Serge Petrenko wrote: > > > 05.04.2021 16:18, Vladislav Shpilevoy пишет: >> Hi! Thanks for the patch! >> >> On 02.04.2021 16:58, Serge Petrenko wrote: >>> Send the first report as soon as instance's initial configuration >>> finishes. >>> >>> Closes #5750 >>> --- >>> diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua >>> index d00eedf39..2ce768642 100644 >>> --- a/src/box/lua/feedback_daemon.lua >>> +++ b/src/box/lua/feedback_daemon.lua >>> @@ -345,7 +345,7 @@ local function guard_loop(self) >>>       while true do >>>             if get_fiber_id(self.fiber) == 0 then >>> -            self.fiber = fiber.create(feedback_loop, self) >>> +            self.fiber = fiber.new(feedback_loop, self) >> Why? > > With fiber.create() feedback daemon proceeds to sending the "initial report" even before > lua's box.cfg() exits. This shouldn't break anything, as far as I understand, but > `tarantoolctl.test.lua` failed on my machine without this change. But box.cfg yields. Does it mean it still ends before box.cfg ends too, if box.cfg yields?