From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0A0BB24312 for ; Wed, 9 May 2018 10:31:01 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R3aky2yqlhtJ for ; Wed, 9 May 2018 10:31:00 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 302B2227AC for ; Wed, 9 May 2018 10:31:00 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE From: "n.pettik" In-Reply-To: <2050311525824390@web59j.yandex.ru> Date: Wed, 9 May 2018 17:30:55 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <225ED31B-14F7-4BF1-9383-2100722DFEF2@tarantool.org> References: <2050311525824390@web59j.yandex.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: roman.habibov1@yandex.ru Please, read guidelines carefully. >sql: Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE According to our docs: =E2=80=94 2. Try to limit the subject line to 50 characters or so. =E2=80=94 3. Start the subject line with a capital letter unless it = prefixed with a subsystem name and semicolon=E2=80=A6 Also, it is not clear what have you done with these =E2=80=99tests=E2=80=99= : removed/fixed/added etc. >+ >+-- gh-2166 Tables with TEMP and TEMPORARY were removed before. >+ =20 Leading space at the last line. Enable showing whitespaces to avoid such = codestyle violations. >+ }) >+test:do_catchsql_test( >+ "temporary", >+ 1, "near \"TEMPORARY\": syntax error" >+ -- >+ }) >test:do_execsql2_test( Separate tests with blank line. I would also add tests (or just rewrite yours) which check that complete = CREATE TABLE statement doesn=E2=80=99t support TEMP clause: CREATE TEMP TABLE t1(=E2=80=A6); CREATE TEMPORARY TABLE t1(=E2=80=A6);=