From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4236E27F276; Thu, 2 Feb 2023 11:54:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4236E27F276 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1675328061; bh=5PwblHvwLJ5rLgwC/Pn0sDbV4drZIQ3oKRO68Ei49K4=; h=Date:In-Reply-To:To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=r05hzOz7g/6Wqqgf1x4qyyCb2KdCvmBlxHMV+1O7fSyeogmvn3aM2BpRkyQqniRKD MplKvo8M+QjZRHfBNjcS0diO4EcJSQjSuG5BRpTuxWfgC1HG653vaF1Dl5lXLarC0F 5V8+kOG9pJuj6beExyZxGoX1Ai5kwSMmxBcfWWKw= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D5170209901 for ; Thu, 2 Feb 2023 11:54:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D5170209901 Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1pNVMI-0001d0-U8; Thu, 02 Feb 2023 11:54:19 +0300 Message-Id: <21640F21-027F-4F25-9572-6F583B87F926@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_6796A2CC-5996-4BAA-8E77-E74B5D4AE462" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Date: Thu, 2 Feb 2023 11:54:08 +0300 In-Reply-To: To: Sergey Kaplun References: <344EA858-7445-4DD9-8A4F-625F940614D7@tarantool.org> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D919194CF4FC660488DBEAA600CFE3E713BC9BB5F2D7A95A182A05F5380850405304677B469D8E2F7F974D0C7389AE725DC92410179C450EF7B42A49399BCDED X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A41A3668A00E2636EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374E88016F1B7D8D248638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D891D32767D576586B2C96717B9B28B445117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520CCD848CCB6FE560CC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE902A1BE408319B29C766E17BBE5724E9D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3AD0E433DBF1FBFA39735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637AD0424077D726551EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A63B03BCD35E0C0A6959D635CD91E1FB81F78C424093C9B98E4ADF203B8E5BE1625DA8C66DC368F41D7E09C32AA3244CB3E120CB2CA3DBAF4E987056F67B6FB43C6EB905E3A8056B927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojUCXb8yEWKAlmRHrQseiTaQ== X-Mailru-Sender: 5AA3D5B9D8C486465A7E7C46D91E24B016D5A446B1223EBF7F974D0C7389AE72C2EB5FBD3A89CC3260D8632BEC246C7D55B4A2144138A8805FC805B5969CB4993EE16157CC7DAB4272D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] ci: introduce workflow for exotic builds X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: sergos via Tarantool-patches Reply-To: sergos Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" --Apple-Mail=_6796A2CC-5996-4BAA-8E77-E74B5D4AE462 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi! Thanks for the update! That=E2=80=99s exactly was on my mind - an additional job, not changing = this one. LGTM. Sergos > On 1 Feb 2023, at 11:52, Sergey Kaplun wrote: >=20 > Hi, Igor! >=20 > Thanks for reply:)! >=20 > On 01.02.23, Igor Munkin wrote: >> Hi everyone, >>=20 >> On 30.01.23, Sergey Kaplun wrote: >>=20 >> >>=20 >>>>=20 >>>> Shall we add the -DLUAJIT_ENABLE_CHECKHOOK and = -DLUAJIT_SMART_STRINGS=3D1 since they are in Tarantool by default? >>>=20 >>> -DLUAJIT_SMART_STRINGS=3D1 is set by default, so it's OK not to set = it >>> mannually. >>>=20 >>> OTOH, -DLUAJIT_ENABLE_CHECKHOOK is not set by default. >>> I prefer not to set it for this particular workflow, because I plan = to >>> use it for very specific builds (even impossible for Tarantool) for >>> example with -DLUAJIT_DISABLE_JIT=3DON, -DLUAJIT_DISABLE_FFI=3DON = flags. >>> Also, this flag is not set for default LuaJIT testing, so I tried to >>> make those workflows look similar. >>> But if we want to add this flag for default build or testing we = should >>> add it for this workflow too. >>> CC-ed Igor to hear his opinion. >>=20 >> I'm totally for adding such workflows, but I suggest to do it in a >> separate patch. Sergey, this is on you. >=20 > OK, so I'll add exotic -DLUAJIT_ENBALE_CHECKHOOK job after this patch > will be merged to avoid rebases. >=20 >>=20 >>>=20 >>>>=20 >>=20 >> >>=20 >>>=20 >>> --=20 >>> Best regards, >>> Sergey Kaplun >>=20 >> --=20 >> Best regards, >> IM >=20 > --=20 > Best regards, > Sergey Kaplun --Apple-Mail=_6796A2CC-5996-4BAA-8E77-E74B5D4AE462 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hi!

Thanks for the = update!
That=E2=80=99s exactly was on my mind - an additional = job, not changing this = one.
LGTM.

Sergos

On 1 Feb 2023, at 11:52, Sergey Kaplun = <skaplun@tarantool.org> wrote:

Hi, Igor!

Thanks for = reply:)!

On 01.02.23, Igor Munkin = wrote:
Hi = everyone,

On 30.01.23, Sergey Kaplun = wrote:

<snipped>


Shall we add the -DLUAJIT_ENABLE_CHECKHOOK and = -DLUAJIT_SMART_STRINGS=3D1 since they are in Tarantool by = default?

-DLUAJIT_SMART_STRINGS=3D1 is set by = default, so it's OK not to set it
mannually.

OTOH, = -DLUAJIT_ENABLE_CHECKHOOK is not set by default.
I prefer not to set = it for this particular workflow, because I plan to
use it for very = specific builds (even impossible for Tarantool) for
example with = -DLUAJIT_DISABLE_JIT=3DON, -DLUAJIT_DISABLE_FFI=3DON flags.
Also, = this flag is not set for default LuaJIT testing, so I tried to
make = those workflows look similar.
But if we want to add this flag for = default build or testing we should
add it for this workflow = too.
CC-ed Igor to hear his opinion.

I'm totally = for adding such workflows, but I suggest to do it in a
separate = patch. Sergey, this is on you.

OK, so = I'll add exotic -DLUAJIT_ENBALE_CHECKHOOK job after this patch
will be merged to avoid = rebases.





<snipped>


-- 
Best regards,
Sergey = Kaplun

-- 
Best = regards,
IM

-- 
Best regards,
Sergey = Kaplun

= --Apple-Mail=_6796A2CC-5996-4BAA-8E77-E74B5D4AE462--