On 1 Feb 2023, at 11:52, Sergey Kaplun <skaplun@tarantool.org> wrote:
Hi, Igor!Thanks for reply:)!On 01.02.23, Igor Munkin wrote:Hi everyone,
On 30.01.23, Sergey Kaplun wrote:
<snipped>
Shall we add the -DLUAJIT_ENABLE_CHECKHOOK and -DLUAJIT_SMART_STRINGS=1 since they are in Tarantool by default?
-DLUAJIT_SMART_STRINGS=1 is set by default, so it's OK not to set it
mannually.
OTOH, -DLUAJIT_ENABLE_CHECKHOOK is not set by default.
I prefer not to set it for this particular workflow, because I plan to
use it for very specific builds (even impossible for Tarantool) for
example with -DLUAJIT_DISABLE_JIT=ON, -DLUAJIT_DISABLE_FFI=ON flags.
Also, this flag is not set for default LuaJIT testing, so I tried to
make those workflows look similar.
But if we want to add this flag for default build or testing we should
add it for this workflow too.
CC-ed Igor to hear his opinion.
I'm totally for adding such workflows, but I suggest to do it in a
separate patch. Sergey, this is on you.
OK, so I'll add exotic -DLUAJIT_ENBALE_CHECKHOOK job after this patchwill be merged to avoid rebases.
<snipped>
--
Best regards,
Sergey Kaplun
--
Best regards,
IM
-- Best regards,Sergey Kaplun