From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D79664C885; Thu, 14 Jan 2021 10:49:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D79664C885 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610610594; bh=SuhCJazChGSpjlYQ1wDsE0Bs2HVtNa/A0fJL/sCDDyw=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=OPUEoyxglFJpgSyfUV2ZybSeJxKphKn6BEcNSh17zF+rFbIWI14kCUKCxy7IRTWJD LKOn+8/OM2gVnNezGFVlFn/KJbaEKANbX7/XIjaP+10EpwGtcT0sCuG7Z5o4iqIAWS +pd9/GTCMTPb/cLa1a1bo+AHvOU3gruEVmtK3Vfc= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C44DA4C883 for ; Thu, 14 Jan 2021 10:49:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C44DA4C883 Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1kzxOB-0005pd-Sl; Thu, 14 Jan 2021 10:49:52 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, lvasiliev@tarantool.org References: <08266e7e73c778c80dd9954b4e45fe1d5cfa9b21.1608647958.git.estetus@gmail.com> <63ceba2d-9aa3-84db-9d56-7d15a2053167@tarantool.org> <24c86655-d972-ff0c-feef-a42f2bb16dfb@tarantool.org> Message-ID: <2157981c-bfb3-3c4c-0090-fdd0931f88fa@tarantool.org> Date: Thu, 14 Jan 2021 10:49:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD81CC0669AF3BE2AC14A0BAA29BC1501600894C459B0CD1B948ADFE0A7E2B07773DFBBA31B3EE3CBF932B41B4FD70BD5105C8B9D5B862C5B4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71BDE6A359BD5B800EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063767500BC4578134A08638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC9EF150C440D65FAE40E718254A6C95F2DB6C011C5C37B04F389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07734D68A6916D8318941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D6FBC3EC642A93BBCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C224946906D4753B15FC03AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F79006372A3D35F7DF4016F2EC76A7562686271EEC990983EF5C032935872C767BF85DA29E625A9149C048EE0A3850AC1BE2E7354DCCFF368A6260CF4AD6D5ED66289B524E70A05D1297E1BB35872C767BF85DA227C277FBC8AE2E8B15B11194B854C5ED75ECD9A6C639B01B4E70A05D1297E1BBC6867C52282FAC85D9B7C4F32B44FF57AA1DF4CB901976EF00306258E7E6ABB4E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5204536F2840AD2850A1BE509431DEB2B3EC98B5AFD49DBCBD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758F9E841AEAEC4F2C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3482189E76C6218D8F0E692A1BA8B0EE27A328E1C21515D5F5052EF43BA4F356077164777F9744BA641D7E09C32AA3244CFFA5643D292C8C362BAEC175E0AF1B54250262A5EE9971B0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9kdO2HH36x6+qjgmsSenUw== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458FCD1C240324FBD4644024D6C884226FF7076578F7B2D7F70282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/3] luacheck: fix warnings in test/box X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 13.01.2021 19:38, Vladislav Shpilevoy wrote: > Hi! Thanks for the fixes! > > Consider my fixes on top of this commit on the branch, and below with > explanations. Thanks for your fixes! I have squashed your commit. > @@ -50,11 +50,11 @@ local function test_insert_delete(n) > end > > return { > - clear = clear; > - create_space = create_space; > - delete = delete; > - drop_space = drop_space; > - dump = dump; > - fill = fill; > - test_insert_delete = test_insert_delete; > + clear = clear, > + create_space = create_space, > + delete = delete, > + drop_space = drop_space, > + dump = dump, > + fill = fill, > + test_insert_delete = test_insert_delete, > ==================== > > We don't use ';' anywhere. It may still be used in some old code, > but not in the new code. I have no idea though if it is stated > anywhere formally. actually there is a rule in Lua guideline [1]: "do not use semicolon as table separator (only comma)" 1. https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/#idioms-and-patterns