From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D22434696C3 for ; Thu, 2 Apr 2020 13:18:05 +0300 (MSK) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) From: Chris Sosnin In-Reply-To: <10e401d608cf$20ef8970$62ce9c50$@tarantool.org> Date: Thu, 2 Apr 2020 13:18:04 +0300 Content-Transfer-Encoding: 7bit Message-Id: <21410A2F-C0E3-4AB7-BE1E-724774BE0D5A@tarantool.org> References: <10e401d608cf$20ef8970$62ce9c50$@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 0/4] session settings fixes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Timur Safin Cc: tarantool-patches@dev.tarantool.org > On 2 Apr 2020, at 12:14, Timur Safin wrote: > > I'm late here on this party, but I very much dislike proposed syntax of > > SETTING SET configuration_name = value; > > It feels not SQL-ish, and I see no much value introducing new statement > while there is still SET statement available. > > Why we could not simply use something like: > SET box.session.settings.name = value; > ? > > Thanks, > Timur It was SET = in the first version. However, we agreed on this syntax being too generic for configuring session settings, so I added SETTING keyword. > > > : -----Original Message----- > : From: Tarantool-patches On > : Behalf Of Chris Sosnin > : Sent: Monday, March 30, 2020 12:14 PM > : To: v.shpilevoy@tarantool.org; korablev@tarantool.org; tarantool- > : patches@dev.tarantool.org > : Subject: [Tarantool-patches] [PATCH 0/4] session settings fixes > : > : issue #1:https://github.com/tarantool/tarantool/issues/4711 > : issue #2:https://github.com/tarantool/tarantool/issues/4712 > : branch:https://github.com/tarantool/tarantool/tree/ksosnin/gh-4712- > : session-settings-v2 > : > : Chris Sosnin (4): > : box: replace session_settings modules with a single array > : box: add binary search for _session_settings space > : box: provide a user friendly frontend for accessing session settings > : sql: provide a user friendly frontend for accessing session settings > : > : extra/mkkeywordhash.c | 1 + > : src/box/lua/session.c | 111 +++++++++ > : src/box/session.cc | 1 + > : src/box/session.h | 2 + > : src/box/session_settings.c | 214 +++++++++++------- > : src/box/session_settings.h | 53 +++-- > : src/box/sql.c | 5 - > : src/box/sql/build.c | 104 ++++----- > : src/box/sql/parse.y | 5 + > : src/box/sql/sqlInt.h | 11 + > : src/box/sql/vdbe.c | 50 ++++ > : ...rontend.result => session_settings.result} | 147 ++++++++++-- > : ...end.test.lua => session_settings.test.lua} | 61 ++++- > : 13 files changed, 589 insertions(+), 176 deletions(-) > : rename test/box/{gh-4511-access-settings-from-any-frontend.result => > : session_settings.result} (71%) > : rename test/box/{gh-4511-access-settings-from-any-frontend.test.lua => > : session_settings.test.lua} (64%) > : > : -- > : 2.21.1 (Apple Git-122.3) > >