From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1178A27D04 for ; Fri, 20 Jul 2018 12:43:09 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k8QD77z_XPjk for ; Fri, 20 Jul 2018 12:43:09 -0400 (EDT) Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C020326EA9 for ; Fri, 20 Jul 2018 12:43:08 -0400 (EDT) From: "n.pettik" Message-Id: <2123605D-8D6C-43A3-846F-735E4C2C7FC2@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_3D2A9CE5-FFDF-4431-947F-AFB6A8F98E0E" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH] sql: xfer optimization issue Date: Fri, 20 Jul 2018 19:43:00 +0300 In-Reply-To: References: <5BB99B27-5F86-4664-AAD5-57A22ECED854@tarantool.org> <93E4DAEA-EF90-479D-9F62-3D1CEB3CBE3F@tarantool.org> <20180628101839.fhnijezdpwviohop@tkn_work_nb> <20180709155006.fwrikbznqk23ger5@tkn_work_nb> <79D03E96-0BD0-418D-9DB2-45318C734628@tarantool.org> <8B8D5501-075D-4BEB-B282-35B0B81CD555@tarantool.org> <605B15EF-BD1C-4B03-8A9F-6E6225076812@tarantool.org> <12B62C73-9BEC-49FA-B3FD-590C445CF25B@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: "N. Tatunov" --Apple-Mail=_3D2A9CE5-FFDF-4431-947F-AFB6A8F98E0E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 LGTM. > diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c > index 3c3bf37..4f52fa5 100644 > --- a/src/box/sql/insert.c > +++ b/src/box/sql/insert.c > @@ -1869,7 +1869,7 @@ xferOptimization(Parse * pParse, /* = Parser context */ > * table (tab1) is initially empty. > */ > =20 > - /* The Vdbe we're building*/ > + /* The Vdbe struct we're building. */ You misunderstood me. What I mean is: struct Vibe *v =3D =E2=80=A6; > Vdbe *v =3D sqlite3GetVdbe(pParse); --Apple-Mail=_3D2A9CE5-FFDF-4431-947F-AFB6A8F98E0E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
LGTM.

diff --git = a/src/box/sql/insert.c b/src/box/sql/insert.c
index = 3c3bf37..4f52fa5 100644
--- = a/src/box/sql/insert.c
+++ = b/src/box/sql/insert.c
@@ -1869,7 +1869,7 @@ = xferOptimization(Parse * pParse, /* Parser context */
  =  * table (tab1) = is initially empty.
   */
 
- /* The Vdbe we're building*/
+ = /* The Vdbe struct we're building. = */

You = misunderstood me. What I mean is:

struct Vibe *v =3D =E2=80=A6;

  = Vdbe *v =3D = sqlite3GetVdbe(pParse);

= --Apple-Mail=_3D2A9CE5-FFDF-4431-947F-AFB6A8F98E0E--