Re: [Tarantool-patches] [PATCH 2/3 v2] replication: add test with random leaders promotion and demotion

[Serge Petrenko <sergepetrenko@tarantool.org>]

12.11.2020 12:10, sergeyb@tarantool.org пишет:
> From: Sergey Bronnikov<sergeyb@tarantool.org>
>
> Part of #5055
> Part of #5144


Hi! Thanks for the patch!


> ---
>   test/replication/qsync.lua                    |  30 ++++
>   test/replication/qsync1.lua                   |   1 +
>   test/replication/qsync2.lua                   |   1 +
>   test/replication/qsync3.lua                   |   1 +
>   test/replication/qsync4.lua                   |   1 +
>   test/replication/qsync5.lua                   |   1 +
>   test/replication/qsync_random_leader.result   | 139 ++++++++++++++++++
>   test/replication/qsync_random_leader.test.lua |  68 +++++++++
>   8 files changed, 242 insertions(+)
>   create mode 100644 test/replication/qsync.lua
>   create mode 120000 test/replication/qsync1.lua
>   create mode 120000 test/replication/qsync2.lua
>   create mode 120000 test/replication/qsync3.lua
>   create mode 120000 test/replication/qsync4.lua
>   create mode 120000 test/replication/qsync5.lua
>   create mode 100644 test/replication/qsync_random_leader.result
>   create mode 100644 test/replication/qsync_random_leader.test.lua
>
> diff --git a/test/replication/qsync.lua b/test/replication/qsync.lua
> new file mode 100644
> index 000000000..b15cc18c9
> --- /dev/null
> +++ b/test/replication/qsync.lua
> @@ -0,0 +1,30 @@
> +#!/usr/bin/env tarantool
> +
> +-- get instance name from filename (qsync1.lua => qsync1)
> +local INSTANCE_ID = string.match(arg[0], "%d")
> +
> +local SOCKET_DIR = require('fio').cwd()
> +
> +local function instance_uri(instance_id)
> +    return SOCKET_DIR..'/qsync'..instance_id..'.sock';
> +end
> +
> +-- start console first
> +require('console').listen(os.getenv('ADMIN'))
> +
> +box.cfg({
> +    listen = instance_uri(INSTANCE_ID);
> +    replication = {
> +        instance_uri(1);
> +        instance_uri(2);
> +        instance_uri(3);
> +        instance_uri(4);
> +        instance_uri(5);
> +    };
> +})
> +
> +box.once("bootstrap", function()
> +    box.cfg{replication_synchro_timeout = 1000, replication_synchro_quorum = 5}
> +    box.cfg{read_only = false}

You may move these box.cfg calls to the initial box.cfg above.


> +    box.schema.user.grant("guest", 'replication')
> +end)
> diff --git a/test/replication/qsync1.lua b/test/replication/qsync1.lua
> new file mode 120000
> index 000000000..df9f3a883
> --- /dev/null
> +++ b/test/replication/qsync1.lua
> @@ -0,0 +1 @@
> +qsync.lua
> \ No newline at end of file
> diff --git a/test/replication/qsync2.lua b/test/replication/qsync2.lua
> new file mode 120000
> index 000000000..df9f3a883
> --- /dev/null
> +++ b/test/replication/qsync2.lua
> @@ -0,0 +1 @@
> +qsync.lua
> \ No newline at end of file


> +
> +-- Testcase body.
> +for i=1,300 do                                                                 \
> +    test_run:eval(SERVERS[current_leader_id],                                  \
> +        string.format("box.space.sync:insert{%d}", i))                         \
> +    new_leader_id = random(current_leader_id, #SERVERS)                        \
> +    log.info(string.format("current leader id %d, new leader id %d",           \
> +                           current_leader_id, new_leader_id))                  \
> +    test_run:eval(SERVERS[new_leader_id], "box.ctl.clear_synchro_queue()")     \
> +    replica = random(new_leader_id, #SERVERS)                                  \
> +    test_run:wait_cond(function() return test_run:eval(SERVERS[replica],       \
> +                       string.format("box.space.sync:get{%d}", i)) ~= nil end) \
> +    test_run:wait_cond(function() return test_run:eval(SERVERS[current_leader_id], \
> +                       string.format("box.space.sync:get{%d}", i)) ~= nil end) \
> +    current_leader_id = new_leader_id                                          \
> +end


Discussed verbally. Please update the testcase, so that insertions
are done with too high quorum.


> +
> +test_run:switch('qsync1')
> +box.space.sync:count() -- 300
> +
> +-- Teardown.
> +test_run:switch('default')
> +test_run:eval(SERVERS[current_leader_id], 'box.space.sync:drop()')
> +test_run:drop_cluster(SERVERS)
> +box.cfg{                                                                       \
> +    replication_synchro_quorum = orig_synchro_quorum,                          \
> +    replication_synchro_timeout = orig_synchro_timeout,                        \
> +}

-- 
Serge Petrenko