From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EED1612904BC; Wed, 12 Mar 2025 13:32:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EED1612904BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1741775550; bh=ikQnkEWI+gweQiPkZ3t1BB/5NhGFMOmFVWQPLHEcfVU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=WISQE+9R6FnEvS1E2tlY4eZOJmr7O7JD5l7uIxprHrcyViZk6uL7LXPupBIunWdJ7 o2t5T19uyLNcE0JExzNs/tY0sMfC8kenLNoiq649zH0on7dkebZB9E49odckQavfHJ 3An5n6I9x7O6QbzX0BcCJG/LfuJBNtr/m6ZFoq+8= Received: from send242.i.mail.ru (send242.i.mail.ru [95.163.59.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DD63712904BC for ; Wed, 12 Mar 2025 13:32:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DD63712904BC Received: by exim-smtp-69cc44787d-6svnn with esmtpa (envelope-from ) id 1tsJNz-0000000035w-412M; Wed, 12 Mar 2025 13:32:28 +0300 Content-Type: multipart/alternative; boundary="------------V2hncYnm2h0nCHoPi0MzLB8D" Message-ID: <20ab94fb-7942-4492-8d67-c923a00a2fbe@tarantool.org> Date: Wed, 12 Mar 2025 13:32:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <20250310144227.17158-1-skaplun@tarantool.org> <5373b9f3-26f0-455f-97c6-8dd9ebc3eb50@tarantool.org> In-Reply-To: <5373b9f3-26f0-455f-97c6-8dd9ebc3eb50@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD97F948AB408EB4D541A4DDA498017C3734C62E8B634A86416182A05F5380850404C228DA9ACA6FE2724101F9BEF901B733DE06ABAFEAF6705267EB4B4A514B3BC9946DDEB794E692C4ED6240D679448A3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76D34FAA3D8B31588C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6759CC434672EE6371C2A783ECEC0211ADC4224003CC836476D5A39DEEDB180909611E41BBFE2FEB2B7125021FBF1B992FFC67001CA66BA4750C5B0590860BE57140B5E2122F9F34C89FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B292D688DDAD4E7BC389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637D26F802DBF5E8046D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE760F066B5F943C53AEC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C37725542EFDE5E0D335872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A51F6F9B04A12411195002B1117B3ED696CCFFD895BADFA2851BDDAE3D1EA49BEA823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF96D8055DE5B46534C51D0EB4B064C27D558F8CDED7EECAF5A21C98799A0C0C0417C141E43CE0FC0B5FC880DB409560E6757A46272334B072D7D5F54E769AAAA6E3F47F3D5EE573AF111DC66A97D0BFE2913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQiWK+2I7Y2sA5+07TMl9go= X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D61401E49EF2FB3D5B89AA6D5EE0DB6E1EC8DE62253FC0BDC9C390152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------V2hncYnm2h0nCHoPi0MzLB8D Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Please also bump codespell version in .github/workflows/lint.yml. On 11.03.2025 14:13, Sergey Bronnikov via Tarantool-patches wrote: > > Hi, Sergey > > LGTM > > On 10.03.2025 17:42, Sergey Kaplun wrote: >> This patch fixes the typo 'snapshoting' -> 'snapshotting' in the >> . >> Also, it adds `tru` and `fal` to the ignore list since they are used in >> the LuaJIT JIT dump output. >> --- >> >> Branch:https://github.com/tarantool/luajit/tree/skaplun/gh-no-ticket-codespell-2.3.0-fixes >> Note: CI is red due-to integrational testing problems. >> Seehttps://github.com/tarantool/tarantool/pull/11220. >> >> .codespell-ignore-words.txt | 2 ++ >> .../lj-736-BC_UCLO-triggers-infinite-loop.test.lua | 7 ++++--- >> 2 files changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt >> index 757ee53d..1fcceefa 100644 >> --- a/.codespell-ignore-words.txt >> +++ b/.codespell-ignore-words.txt >> @@ -1,3 +1,5 @@ >> +fal >> fpr >> isnt >> nd >> +tru >> diff --git a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua >> index 01dba4bb..3f22c203 100644 >> --- a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua >> +++ b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua >> @@ -35,9 +35,10 @@ local function testcase() >> >> -- Records the trace for which use-def analysis is applied. >> for i = 1, 2 do >> - -- This condition triggers snapshoting and use-def analysis. >> - -- Before the patch this triggers the infinite loop in the >> - -- `snap_usedef()`, so the `goto` is never taken. >> + -- This condition triggers snapshotting and use-def >> + -- analysis. Before the patch this triggers the infinite >> + -- loop in the `snap_usedef()`, so the `goto` is never >> + -- taken. >> if i == 2 then >> goto x >> end --------------V2hncYnm2h0nCHoPi0MzLB8D Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Please also bump codespell version in .github/workflows/lint.yml.

On 11.03.2025 14:13, Sergey Bronnikov via Tarantool-patches wrote:

Hi, Sergey

LGTM

On 10.03.2025 17:42, Sergey Kaplun wrote:
This patch fixes the typo 'snapshoting' -> 'snapshotting' in the
<lj-736-BC_UCLO-triggers-infinite-loop.test.lua>.
Also, it adds `tru` and `fal` to the ignore list since they are used in
the LuaJIT JIT dump output.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-no-ticket-codespell-2.3.0-fixes
Note: CI is red due-to integrational testing problems.
See https://github.com/tarantool/tarantool/pull/11220.

 .codespell-ignore-words.txt                                | 2 ++
 .../lj-736-BC_UCLO-triggers-infinite-loop.test.lua         | 7 ++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt
index 757ee53d..1fcceefa 100644
--- a/.codespell-ignore-words.txt
+++ b/.codespell-ignore-words.txt
@@ -1,3 +1,5 @@
+fal
 fpr
 isnt
 nd
+tru
diff --git a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
index 01dba4bb..3f22c203 100644
--- a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
+++ b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
@@ -35,9 +35,10 @@ local function testcase()
 
     -- Records the trace for which use-def analysis is applied.
     for i = 1, 2 do
-      -- This condition triggers snapshoting and use-def analysis.
-      -- Before the patch this triggers the infinite loop in the
-      -- `snap_usedef()`, so the `goto` is never taken.
+      -- This condition triggers snapshotting and use-def
+      -- analysis. Before the patch this triggers the infinite
+      -- loop in the `snap_usedef()`, so the `goto` is never
+      -- taken.
       if i == 2 then
         goto x
       end
--------------V2hncYnm2h0nCHoPi0MzLB8D--