From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [tarantool-patches] Re: [PATCH 2/2] net.box: fetch '_vcollation' sysview into the module From: Roman Khabibov In-Reply-To: <20190605172850.rrapakadshzxjnjo@esperanza> Date: Thu, 6 Jun 2019 18:22:55 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <20B83146-C27C-422E-A846-3E287490D53F@tarantool.org> References: <8580960460ba5013b81e3a327fc94df2377c06da.1559219194.git.roman.habibov@tarantool.org> <20190604163603.ukdr3qogig5leksl@esperanza> <2F4F2E2A-9C27-42B2-94D8-98513D1398A9@tarantool.org> <20190605172850.rrapakadshzxjnjo@esperanza> To: tarantool-patches@freelists.org Cc: Vladimir Davydov List-ID: > On Jun 5, 2019, at 8:28 PM, Vladimir Davydov = wrote: >=20 > On Wed, Jun 05, 2019 at 08:08:39PM +0300, Roman Khabibov wrote: >>=20 >>> On Jun 4, 2019, at 7:36 PM, Vladimir Davydov = wrote: >>>=20 >>> On Thu, May 30, 2019 at 03:36:03PM +0300, Roman Khabibov wrote: >>>> Fetch "_vcollation" sysview to show collation name instead = collation id. >>>>=20 >>>> Closes #3941 >>>> --- >>>> src/box/lua/net_box.lua | 24 ++++++++++++++++++------ >>>> test/box/net.box.result | 2 +- >>>> test/box/stat_net.result | 4 ++-- >>>> 3 files changed, 21 insertions(+), 9 deletions(-) >>>=20 >>> This one looks good to me, but you probably need to write a doc bot >>> request. >>>=20 >> What should I write in this request? I understood, that you meant >> info about _vcollation existance. >=20 > Yep, something like this I suppose: >=20 > = https://www.tarantool.io/en/doc/2.1/book/box/box_space/#box-space-vspace >=20 > BTW we miss _vsequence documentation. Should be added as well. _vfunc too?=