From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 29CBEDCD1BE; Thu, 19 Dec 2024 12:31:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 29CBEDCD1BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1734600705; bh=jmEsBaD/2P7M9cfO0++KXZT1+hQRwb5/+4BoxRMxPSg=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=BxD5TfW6n1F6c2mBqoRql/vcbSlJQIH5ANpQ9HKYGFk+AMcery7Knv/AhE8NzwjkV lZimjIvH1T1oosClo90e2ozc+9rrPRTn2WUSHCPWRj7tnO2FJB65gU6xzei9ShHwmP 7wSjsbTX/Ihfx/QAAmrzBCy83dC/0IHIFmtbEn/8= Received: from send103.i.mail.ru (send103.i.mail.ru [89.221.237.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 503EF57A5C1 for ; Thu, 19 Dec 2024 12:31:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 503EF57A5C1 Received: by exim-smtp-cc4f974bf-zkwdj with esmtpa (envelope-from ) id 1tOCsg-00000000HjY-0d5j; Thu, 19 Dec 2024 12:31:42 +0300 To: Maxim Kokryashkin , Sergey Bronnikov Date: Thu, 19 Dec 2024 12:30:41 +0300 Message-ID: <20241219093041.14681-1-skaplun@tarantool.org> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD90D1D1AB545089981E45019BE5F1587EE0EB21171BC1D3325182A05F538085040832AB817DE0FEC073DE06ABAFEAF67051B900FF02C02DA3109821804DCF68B4AE230A8568C332C38 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7548C33FFD72831AFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372BE3E2E75E3847F48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EF308F1DB50750CC033310E872D23E03EE54993003F17BE5CC7F00164DA146DAFE8445B8C89999728AA50765F7900637DCE3DBD6F8E38AFD389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8ED96AA85C75E140D117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407978DA827A17800CE773BC869C69ECC1572DBA43225CD8A89FB26E97DCB74E6252262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A56C2859952115647C5002B1117B3ED69608636EC8DB2966C8108A05421C070DB8823CB91A9FED034534781492E4B8EEADB71243024C627CEAC79554A2A72441328621D336A7BC284946AD531847A6065A535571D14F44ED41 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742D3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFE47E6D112EAB2689170DF98111B296DF5E0C44E8F9D4615C5643BB1FB33B62B8F33D08354E2B7C9224A398DE2C7926EDF5BE44AD777EB4C5311E7AD89E58497DF2BA410F04192D15C226CC413062362A913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfZ9BPZgVRhrKPsNQ1MVX6w== X-DA7885C5: EA376F8BC1782FF8F255D290C0D534F9B5B163D6F8CA71941FDE8C1EF163DBDBC85A3A2255C4D3945B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA219940C1850A3275A643CBD7D136B2619E010BD9B33AB4A776FE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: [Tarantool-patches] [PATCH luajit] test: harden skipcond for libc in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" The `strtod parsing` subtest in the checks the results yielded by the `strtod()` via FFI call. In glibc versions before 2.28 it returns an incorrect result (NaN instead of inf) for "0x3p1023" [1]. This patch hardens the skipcond for this test for a smaller version of the libc installed. [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=23279 --- Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-glibc-versions The CI failure for libc 2.23 (ubuntu 16): https://github.com/tarantool/tarantool/actions/runs/12376159316/job/34542626889?pr=10949#step:5:13916 The CI failure for libc 2.24 (debian 9): https://github.com/tarantool/tarantool/actions/runs/12376159307/job/34542633454?pr=10949#step:5:13859 The CI failure for libc 2.27 (ubuntu 18): https://github.com/tarantool/tarantool/actions/runs/12376159278/job/34542625496?pr=10949#step:5:11743 The CI pass for libc 2.31 (ubuntu 20): https://github.com/tarantool/tarantool/actions/runs/12376159289/job/34542630993?pr=10949 test/LuaJIT-tests/lib/base/tonumber_scan.lua | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/LuaJIT-tests/lib/base/tonumber_scan.lua b/test/LuaJIT-tests/lib/base/tonumber_scan.lua index ac7d68a4..800c57b0 100644 --- a/test/LuaJIT-tests/lib/base/tonumber_scan.lua +++ b/test/LuaJIT-tests/lib/base/tonumber_scan.lua @@ -186,9 +186,11 @@ do --- tonumber parsing test_conv(tonumber) end --- Skip for the old libc version with the bug in the `strtod()`. --- See also https://sourceware.org/bugzilla/show_bug.cgi?id=16151. -do --- strtod parsing -libc<2.19 +-- Skip for the old libc version with the bugs in the `strtod()`. +-- Affected versions: +-- * <2.19: https://sourceware.org/bugzilla/show_bug.cgi?id=16151. +-- * <2.28: https://sourceware.org/bugzilla/show_bug.cgi?id=23279. +do --- strtod parsing -libc<2.28 test_conv(function(s) local d = ffi.C.strtod(s, e) return (e[0][0] == 0 and #s ~= 0) and d or nil -- 2.47.0