From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 863A6CE25C0; Mon, 2 Dec 2024 16:52:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 863A6CE25C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1733147535; bh=+9sRdqm9L+1v5sg6nbywub5pnaLwQK0ZgYiFozbRlFg=; h=To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=VJBaqpoDmrYs1LgPz1LgEYmDOGN1/UwseFi5m+k5AE3dGCxqW5TDB5BZcM8HLNbRp DT0G9SZWwGct4LrSyHe36OSP58sNRbVU2jcGo7cnazRlrlaius3ZaQydTTb9vHxgXe Z0VChJrmcfraFI/YaXcQUN8BLQZRjcI3TOlw6HTk= Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9CA414A1536 for ; Mon, 2 Dec 2024 16:52:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9CA414A1536 Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-53de7321675so4397540e87.2 for ; Mon, 02 Dec 2024 05:52:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733147533; x=1733752333; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GuZaV7TazY2Lp5T9qQBwkqrNwAtn2kUGzHAjY292EGA=; b=jClE/W45LrQDUyjEezxuRq8zDyEKrHjI3w5CVCM8pAVZle2XOW2jgyZXYnXPmBBrkE pvOHunq3uz+DX1906JOh5MQcdqUvr3vTcG4gGCOi74ontMNn/gdbeEm6/LO7soI4jL1H LZ8UgeACkN7yi8N5jfIXuKQWeOQvWted8lsCes3bk96CRqPv3bXiAejsH10UHfWVCfWr yBMVi5a0CDFh6kkavx3HiXitKesvRG/XG1EOoMaHFveQBOPzJPJEsPBhhviw9A09EjLT zW65y0CYqIZAp0FRQ8d3L47HNz6LUIl2+taUL2ovg/Vmjz9Jjr4gZr9clwnnucfRNHP9 tnlQ== X-Gm-Message-State: AOJu0Yy75ZDNMDomdcC5Y7exrbKVaroVQUQbOgl7KQztkVSglb4OhjBb KejX+3mrh9TlOXnpPqo8KpA+609YmFhQdXLxmfMWBazCRhntoL8WavKxW5yc X-Gm-Gg: ASbGncv5Bp2+HdDaXwHfEchflVtY9+9I8QKAcPXDycBGOdDR2tJdJownQDxvw8Y3pCz WvlA+8G0YZJW16fUMesZzwBc2mh3t6/78sayY/9jdpIHq4qJf3jVJR4DgadZcsmm69Oh/PtgN9d jinUK56mPgBh12jSBjfI7X2daieZjA+RF+fcAkRBkIcvzKwGNMWbNgfDkqo55V2FSLkJVQ2m7F1 XCZnX32+LIDlrl7N2KVHrD378HLREaD9B153oD6l6YZgOQCsuxI5/pY5XQ9GVPeRnAiZPo92iom QOU= X-Google-Smtp-Source: AGHT+IETc+nOIbrOJ5hmRjVNU7ufTOmlLPq3ezdS62ggAh9nb2vtQTAOGRJV8+ITpbA7Cm0+fome6A== X-Received: by 2002:a05:6512:12cb:b0:53d:d405:907 with SMTP id 2adb3069b0e04-53df00a9870mr12640309e87.5.1733147532500; Mon, 02 Dec 2024 05:52:12 -0800 (PST) Received: from mandesero.www.tendawifi.com ([85.89.127.21]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53df6496a10sm1455125e87.203.2024.12.02.05.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2024 05:52:12 -0800 (PST) To: tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, m.kokryashkin@tarantool.org Cc: Maksim Tyushev Date: Mon, 2 Dec 2024 13:52:09 +0000 Message-Id: <20241202135211.3714-1-mandesero@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v4 luajit 0/2] Enable running tests with Valgrind, add CI Valgrind testing workflow X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: mandesero--- via Tarantool-patches Reply-To: mandesero@gmail.com Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" From: Maksim Tyushev Changes in v4: - Replaced the `VALGRIND_OPTIONS` variable with `VALGRIND_OPTS`, which is provided by Valgrind. - Enabled running `tarantool-c-tests` under Valgrind: * Disabled the `tarantool-c-tests/gh-8594-sysprof-ffunc-crash.c_test` due to timeout. - Renamed the variable for skipping tests to `LUAJIT_TEST_USE_VALGRIND` and setted it via `LUA_TEST_ENV_MORE`. - Added the `--error-exitcode=1` flag to `VALGRIND_OPTS` in CI for stricter error handling. Notes: > From: Sergey Kaplun > Also, I've found that tests from LuaJIT-tests suite reports tons of the > assertions, but still the suite passes. This should be fixed: > > I suppose that we need to set `--error-exitcode` option as well. > Same for PUC-Rio-Lua-5.1-tests, lua-Harness-test. > ... I noticed that Valgrind generates a significant number of reports, but it seems these are merely warnings or informational messages. At the end, the errors appear to be suppressed, as indicated in the output. | 1/2 Test #1: LuaJIT-tests-deps ................ Passed 0.50 sec | test 2 | Start 2: test/LuaJIT-tests | | 2: Test command: /usr/bin/valgrind "--suppressions=/home/mandesero/myforks/luajit/src/lj.supp" "/home/mandesero/myforks/luajit/build/src/luajit" "-e" "dofile[[/home/mandesero/myforks/luajit/test/luajit-test-init.lua]]" "/home/mandesero/myforks/luajit/test/LuaJIT-tests/test.lua" "+slow" "+ffi" "+bit" "+jit" | | 2: --6813-- used_suppression: 62656 Optimized string compare /home/mandesero/myforks/luajit/src/lj.supp:38 | 2: ==6813== | 2: ==6813== ERROR SUMMARY: 4707 errors from 27 contexts (suppressed: 62656 from 111) Same for others tests. > Also, what do you think about enabling option `--track-fds` for the CI > (maybe in the separate patch set). Enabling the `--track-fds` option for the CI sounds like a good idea. However, I think it would be better to do this in a separate patch set. Branch: https://github.com/tarantool/luajit/tree/mandesero/lj-3705-turn-off-strcmp-opt-in-debug -- Best regards, Maksim Tiushev Maksim Tiushev (2): cmake: run tests with Valgrind ci: add Valgrind testing workflow .github/actions/setup-valgrind/README.md | 12 +++ .github/actions/setup-valgrind/action.yml | 12 +++ .github/workflows/valgrind-testing.yaml | 99 +++++++++++++++++++ CMakeLists.txt | 5 + test/CMakeLists.txt | 16 +++ test/tarantool-c-tests/CMakeLists.txt | 9 +- .../gh-8594-sysprof-ffunc-crash.test.c | 7 ++ .../gh-7745-oom-on-trace.test.lua | 1 + .../lj-1034-tabov-error-frame.test.lua | 1 + .../lj-512-profiler-hook-finalizers.test.lua | 5 +- .../lj-726-profile-flush-close.test.lua | 5 +- .../profilers/gh-5688-tool-cli-flag.test.lua | 2 + ...4-add-proto-trace-sysprof-default.test.lua | 2 + .../profilers/misclib-sysprof-lapi.test.lua | 2 + 14 files changed, 175 insertions(+), 3 deletions(-) create mode 100644 .github/actions/setup-valgrind/README.md create mode 100644 .github/actions/setup-valgrind/action.yml create mode 100644 .github/workflows/valgrind-testing.yaml -- 2.34.1