From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 85CBCED094A; Wed, 18 Sep 2024 11:50:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 85CBCED094A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1726649458; bh=LSTyBfi0/icNgP9ez7QJxxr8n5KDqZeTlnShybaByWA=; h=To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=NVqxV8cgTphktJK8CrtGznj9YpfcjyI6CvKNfUuSLim7c3GFSwyrtXCiL9c9DgcJO BDx/q/NQHcR/SOfXiA/3b7DSsboqojMxsx5m293ZZduQSSFvH+pHi26fZMbLblMGne eiNaUl2PBxJqc6VSZx9qDjJ6TMOKZHSDowGGwuic= Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 74AE7527400 for ; Wed, 18 Sep 2024 11:50:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 74AE7527400 Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-535be093a43so8189865e87.3 for ; Wed, 18 Sep 2024 01:50:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726649456; x=1727254256; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f7pDmqmNdW2j3I36DDx/01fQFHBQTkiW8t+S72mx078=; b=oNl41FWJAMl+NZsllITj1hHXOcF7r8Hg+xZhhAljbXYbNpHVmlwz5TwXjBiMGZ0T5u knoRDgB5sDUKHErhDzVScJ4VFtS4SRCprA7Gn1y3zHuaQTE6xEj3uEM7f0rT4+Qztzna t8Da7C0U/luZeAJs4vpwWDOhVA1DaCRI2QL0cIlkx0HWvLpyqKoNwJEyWMXNKhfjdQUd YOCdkYfX2+o/C+r7S8kTcjImkaC5GukYEPa0mEkHyvQZQc0eWEchw0EVUeBN7+S1lNXt /fn+jiu9oAQOT67dPlvl5RleipInVqNv7YRxOdXNyWb/QZijsDSla6gC60zGPvn+7SKS 8MOw== X-Gm-Message-State: AOJu0YznRPo/gcGoqaOHcNbqh9T7f9K9KqfUdQLfyiMyIODmvtPWhOjw Tl51KZCrvZWyP66wHwFphGPJtVAICptPkT95izfQy+KdOKmUmE0ttLG+y3tuyoc= X-Google-Smtp-Source: AGHT+IHSN2SADz+Fo4i1WhhMPWv8by/KmUVI5zZ1mgBpqi5ph5j9aOXNGorOdQgfF7jlJS05bz3wKw== X-Received: by 2002:a05:6512:3090:b0:533:482f:afb7 with SMTP id 2adb3069b0e04-53678feb201mr11127876e87.39.1726649455083; Wed, 18 Sep 2024 01:50:55 -0700 (PDT) Received: from mandesero.mail.msk ([5.181.62.96]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bc88fedsm4642673a12.92.2024.09.18.01.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 01:50:54 -0700 (PDT) To: tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, m.kokryashkin@tarantool.org Cc: Maksim Tyushev Date: Wed, 18 Sep 2024 08:50:51 +0000 Message-Id: <20240918085053.150351-1-mandesero@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v3 luajit 0/2] Enable running tests with Valgrind, add CI Valgrind testing workflow X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: mandesero--- via Tarantool-patches Reply-To: mandesero@gmail.com Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" From: Maksim Tyushev This patchset enables running LuaJIT tests under Valgrind, with the option to set custom Valgrind options using the `VALGRIND_OPTIONS` environment variable. Please note that this environment variable must be set before building, and any updates to it will require a project rebuild. The patchset also introduces a Valgrind testing workflow with three scenarios: full checks, and two memory checks without leak detection, where memory is filled with `0x00` and `0xff`. Some tests consistently fail under Valgrind due to various reasons, such as SIGPROF, timeouts, or flaky behavior. These tests are disabled when `LUAJIT_USE_VALGRIND=ON`. Branch: https://githb.com/tarantool/luajit/tree/mandesero/lj-3705-turn-off-strcmp-opt-in-debug Issue: https://github.com/tarantool/tarantool/issues/3705 Changes in v3: - Squashed commits 'run tests with Valgrind (1/3 v2)' and 'disable failed tests (3/3 v2)'. - Simplified `.github/actions/setup-valgrind`, now dependents on `.github/actions/setup-linux`. - Updated `test/CMakeLists.txt` with minor adjustments. Maksim Tiushev (2): cmake: run tests with Valgrind ci: add Valgrind testing workflow .github/actions/setup-valgrind/README.md | 12 +++ .github/actions/setup-valgrind/action.yml | 12 +++ .github/workflows/valgrind-testing.yaml | 95 +++++++++++++++++++ CMakeLists.txt | 5 + test/CMakeLists.txt | 16 ++++ test/tarantool-tests/CMakeLists.txt | 3 +- ...4-add-proto-trace-sysprof-default.test.lua | 1 + .../gh-7745-oom-on-trace.test.lua | 1 + .../lj-1034-tabov-error-frame.test.lua | 1 + .../lj-512-profiler-hook-finalizers.test.lua | 4 +- .../lj-726-profile-flush-close.test.lua | 4 +- .../misclib-sysprof-lapi.test.lua | 1 + 12 files changed, 152 insertions(+), 3 deletions(-) create mode 100644 .github/actions/setup-valgrind/README.md create mode 100644 .github/actions/setup-valgrind/action.yml create mode 100644 .github/workflows/valgrind-testing.yaml -- 2.34.1