From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B131D27C101; Thu, 7 Mar 2024 00:47:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B131D27C101 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1709761650; bh=msOrmdnuoSoFNWlw708FjMZ8KMITMr2ZcMqYrFPAGe0=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=wrx4KvjGng5PHPM3jv1okOfy4piNIC8PvjTuQe3QN9wQusm2J2Hmrn+7P/jXNLkLa bXwsv/5GATJwRbRK7UaYTAxb6AvIKnk6dMBwk5Onj0z3vQSAUUNlOQEeNhjxE9aEv3 izq3s8yyTevxxj+lQMknCGVF39naM98eB0fOz5Ng= Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 40DE127C101 for ; Thu, 7 Mar 2024 00:47:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 40DE127C101 Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5131c48055cso211825e87.1 for ; Wed, 06 Mar 2024 13:47:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709761648; x=1710366448; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MDvtiYc3X7lV09MlTN+QeuCNEFIuaCAoNOjN8Emkyjs=; b=X84gKXbj5jondh5uPd9o7Fy/C3iYVrFBqzzB5g7T1/vIQkYrKH6JlH9UMxG7BG6ZMS RpGpGJ+vwujVycuSHs+6DeioTJNf1dY72RXgv+QAQRJUN/dKviVG2PCFNc6tpGyKQvKw IWf9fWUzrPyeIDXjoY8WuOSsF+8mE/3Y7uvU1L2z+zU/kz+8RshvXDDK9V93ZUdwlSaX J6qG3L9Ga/vTc0X1ieWT+dJTyhzr/iDXpgL2gMeQQvQFs1fq3Cyg2yiU0PUh7CSXiZBd 2iN6y+JfmB2W2Upyzs6IbAdaYRPEsQjeB8T22hH/jJxKFRAyyU7W04g9cAB+m+3d7g1V nFsQ== X-Gm-Message-State: AOJu0Yz7/FInpoG0WLugRJvAhwB/rbTfEa5mt55OmJIKeX2OrQ0BbwU9 G2Gca3HrlgPjtDmgwnliix0B3YryComvksQDWjpbYMUcacQp3wwuqnlMoZxMNOk= X-Google-Smtp-Source: AGHT+IFL61r1v9CkrSvrmwcuEqyGNhwslrqyNgPZrTMl3R3OxE4KwhND2B6OIWxbwPqhbvMLbFuycA== X-Received: by 2002:ac2:4ec5:0:b0:513:410c:d0e7 with SMTP id p5-20020ac24ec5000000b00513410cd0e7mr158963lfr.50.1709761647761; Wed, 06 Mar 2024 13:47:27 -0800 (PST) Received: from localhost.localdomain (95-24-11-149.broadband.corbina.ru. [95.24.11.149]) by smtp.gmail.com with ESMTPSA id u17-20020a05651220d100b0051316a84295sm2750470lfr.144.2024.03.06.13.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 13:47:27 -0800 (PST) X-Google-Original-From: Maxim Kokryashkin To: tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, sergeyb@tarantool.org Date: Thu, 7 Mar 2024 00:47:24 +0300 Message-ID: <20240306214724.32017-1-m.kokryashkin@tarantool.org> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH luajit v3] ci: extend tarantool integration testing X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This patch makes use of reusable workflows from the Tarantool repository, so now LuaJIT CI tests integration in all relevant workflows. Also, this patch disables MacOS testing for Tarantool integration since those runs were made nightly in the Tarantool repo. As noted in the documentation [1], it is impossible for a single workflow call tree to include more than 20 workflows. To overcome this limitation, workflows are started in a bunch of separate files. This makes it impossible to depend on LuaJIT-only jobs for integration workflows such as `tarantool-ecosystem.yml` or `tarantool-exotic.yml` since it is impossible to make cross-dependencies between workflow files. The name of a callee workflow cannot be substituted using a matrix [2], so workflow calls are copied and pasted instead. Table below shows which workflows are enabled and why. Workflow name |+/-| Reason ----------------------------------------------------------------- codeql | - | Not relevant to LuaJIT. coverage | + | Long tests for profilers. coverity | - | Cron workflow. debug | + | Tarantool debug build. debug_aarch64 | + | Tarantool debug build. debug_asan_clang | + | Tarantool debug build. default_gcc_centos_7 | + | gcc version (7) freebsd | - | Nightly build. fuzzing | - | Impossible to bump LuaJIT. integration | + | Tarantool ecosystem. jepsen-cluster-txm | - | Manual workflow. jepsen-cluster | - | Manual workflow. jepsen-single-instance-txm | - | Cron workflow. jepsen-single-instance | - | Cron workflow. lango-stale-reviews | - | Cron workflow. lint | - | LuaJIT has its own lint. luajit-integration | + | Exotic LuaJIT options. memtx_allocator_based_on_malloc | - | Not relevant to LuaJIT. osx | - | Nightly build. out_of_source | + | Out of source build. packaging | - | No LuaJIT-relevant variety. perf_cbench | - | Not enabled for PRs. perf_linkbench_ssd | - | Not enabled for PRs. perf_micro | - | Not relevant to LuaJIT. perf_nosqlbench_hash | - | Not enabled for PRs. perf_nosqlbench_tree | - | Not enabled for PRs. perf_sysbench | - | Not enabled for PRs. perf_tpcc | - | Not enabled for PRs. perf_tpch | - | Not enabled for PRs. perf_ycsb_hash | - | Not enabled for PRs. perf_ycsb_tree | - | Not enabled for PRs. publish-module-api-doc | - | No Doxygen in LuaJIT. release | + | Tarantool release build. release_asan_clang | + | Tarantool release build. release_clang | + | Tarantool release build. release_lto | + | Tarantool release build. release_lto_clang | + | Tarantool release build. reusable_build | - | Utility for integration. source | - | Not enabled for PRs. static_build | + | Tarantool static build. static_build_cmake_linux | - | Just an OOS static build. static_build_pack_test_deploy | - | Utility for packaging. submodule_update | - | Not enabled for PRs. [1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations [2]: https://github.com/orgs/community/discussions/45342#discussioncomment-4779360 --- Changes in v3: - Fixed comments as per review by Sergey Kaplun - Fixed comments as per review by Sergey Bronnikov .github/workflows/tarantool-ecosystem.yml | 39 ++++++++ .github/workflows/tarantool-exotic.yml | 67 +++++++++++++ .github/workflows/testing.yml | 117 ++++++++++++++++------ 3 files changed, 193 insertions(+), 30 deletions(-) create mode 100644 .github/workflows/tarantool-ecosystem.yml create mode 100644 .github/workflows/tarantool-exotic.yml diff --git a/.github/workflows/tarantool-ecosystem.yml b/.github/workflows/tarantool-ecosystem.yml new file mode 100644 index 00000000..d8c49638 --- /dev/null +++ b/.github/workflows/tarantool-ecosystem.yml @@ -0,0 +1,39 @@ +# XXX: A single call tree for reusable workflows can't exceed the +# total of 20 workflows, as stated in the documentation [1]. +# This workflow file was created to avoid this limitation. +# +# [1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations +name: Tarantool ecosystem integration testing + +on: + push: + branches-ignore: + - '**-notest' + - 'upstream-**' + tags-ignore: + - '**' + +concurrency: + # An update of a developer branch cancels the previously + # scheduled workflow run for this branch. However, the default + # branch, and long-term branch (tarantool/release/2.11, + # tarantool/release/2.10, etc) workflow runs are never canceled. + # + # We use a trick here: define the concurrency group as 'workflow + # run ID' + # 'workflow run attempt' because it is a unique + # combination for any run. So it effectively discards grouping. + # + # XXX: we cannot use `github.sha` as a unique identifier because + # pushing a tag may cancel a run that works on a branch push + # event. + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/') + && format('{0}-{1}', github.run_id, github.run_attempt) + || format('{0}-{1}', github.workflow, github.ref) }} + cancel-in-progress: true + +jobs: + test-tarantool-integration: + uses: tarantool/tarantool/.github/workflows/integration.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} diff --git a/.github/workflows/tarantool-exotic.yml b/.github/workflows/tarantool-exotic.yml new file mode 100644 index 00000000..8214c088 --- /dev/null +++ b/.github/workflows/tarantool-exotic.yml @@ -0,0 +1,67 @@ +# XXX: A single call tree for reusable workflows can't exceed the +# total of 20 workflows, as stated in the documentation [1]. +# This workflow file was created to avoid this limitation. +# +# [1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations +name: "Tarantool exotic builds testing" + +on: + push: + branches-ignore: + - '**-notest' + - 'upstream-**' + tags-ignore: + - '**' + +concurrency: + # An update of a developer branch cancels the previously + # scheduled workflow run for this branch. However, the default + # branch, and long-term branch (tarantool/release/2.11, + # tarantool/release/2.10, etc) workflow runs are never canceled. + # + # We use a trick here: define the concurrency group as 'workflow + # run ID' + # 'workflow run attempt' because it is a unique + # combination for any run. So it effectively discards grouping. + # + # XXX: we cannot use `github.sha` as a unique identifier because + # pushing a tag may cancel a run that works on a branch push + # event. + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/') + && format('{0}-{1}', github.run_id, github.run_attempt) + || format('{0}-{1}', github.workflow, github.ref) }} + cancel-in-progress: true + +jobs: + test-tarantool-exotic: + strategy: + fail-fast: false + matrix: + ARCH: [ARM64, x86_64] + BUILDTYPE: [Debug, Release] + GC64: [ON, OFF] + OS: [Linux, macOS] + include: + - BUILDTYPE: Debug + CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug + - BUILDTYPE: Release + CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo + exclude: + - ARCH: ARM64 + GC64: OFF + - OS: macOS + GC64: OFF + name: > + Tarantool + (${{ matrix.OS }}/${{ matrix.ARCH }}) + ${{ matrix.BUILDTYPE }} + GC64:${{ matrix.GC64 }} + # XXX: Only LuaJIT-tests are running in this workflow. + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master + with: + CMAKE_EXTRA_PARAMS: > + -G Ninja + ${{ matrix.CMAKEFLAGS }} + -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }} + arch: ${{ matrix.ARCH }} + os: ${{ matrix.OS }} + revision: ${{ github.sha }} diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index cb4ba57b..b4d037cc 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -1,3 +1,11 @@ +# XXX: A single call tree for reusable workflows can't exceed the +# total of 20 workflows, as stated in the documentation [1]. +# Some other jobs are started in separate workflow files to +# overcome the limitation. The jobs are Tarantool ecosystem +# integration testing (tarantool-ecosystem.yml) and exotic +# Tarantool builds (tarantool-exotic.yml). +# +# [1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations name: Testing on: @@ -83,37 +91,86 @@ jobs: run: cmake --build . --parallel --target LuaJIT-test working-directory: ${{ env.BUILDDIR }} + test-tarantool-coverage: + needs: test-luajit + uses: tarantool/tarantool/.github/workflows/coverage.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} - test-tarantool: - strategy: - fail-fast: false - matrix: - ARCH: [ARM64, x86_64] - BUILDTYPE: [Debug, Release] - GC64: [ON, OFF] - OS: [Linux, macOS] - include: - - BUILDTYPE: Debug - CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug - - BUILDTYPE: Release - CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo - exclude: - - ARCH: ARM64 - GC64: OFF - - OS: macOS - GC64: OFF - name: > - Tarantool - (${{ matrix.OS }}/${{ matrix.ARCH }}) - ${{ matrix.BUILDTYPE }} - GC64:${{ matrix.GC64 }} + test-tarantool-debug: + needs: test-luajit + uses: tarantool/tarantool/.github/workflows/debug.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} + + test-tarantool-debug_aarch64: + needs: test-luajit + uses: tarantool/tarantool/.github/workflows/debug_aarch64.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} + + test-tarantool-debug_asan_clang: + needs: test-luajit + uses: tarantool/tarantool/.github/workflows/debug_asan_clang.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} + + test-tarantool-default_gcc_centos_7: + needs: test-luajit + uses: tarantool/tarantool/.github/workflows/default_gcc_centos_7.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} + + test-tarantool-out_of_source: + needs: test-luajit + uses: tarantool/tarantool/.github/workflows/out_of_source.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} + + test-tarantool-release: + needs: test-luajit + uses: tarantool/tarantool/.github/workflows/release.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} + + test-tarantool-release_asan_clang: + needs: test-luajit + uses: tarantool/tarantool/.github/workflows/release_asan_clang.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} + + test-tarantool-release_clang: + needs: test-luajit + uses: tarantool/tarantool/.github/workflows/release_clang.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} + + test-tarantool-release_lto: + needs: test-luajit + uses: tarantool/tarantool/.github/workflows/release_lto.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} + + test-tarantool-release_lto_clang: + needs: test-luajit + uses: tarantool/tarantool/.github/workflows/release_lto_clang.yml@master + with: + submodule: luajit + revision: ${{ github.sha }} + + test-tarantool-static_build: needs: test-luajit - uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master + uses: tarantool/tarantool/.github/workflows/static_build.yml@master with: - CMAKE_EXTRA_PARAMS: > - -G Ninja - ${{ matrix.CMAKEFLAGS }} - -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }} - arch: ${{ matrix.ARCH }} - os: ${{ matrix.OS }} + submodule: luajit revision: ${{ github.sha }} -- 2.43.2