Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org, skaplun@tarantool.org,
	sergeyb@tarantool.org
Subject: [Tarantool-patches] [PATCH luajit] ci: extend tarantool integration testing
Date: Fri,  1 Mar 2024 11:25:38 +0300	[thread overview]
Message-ID: <20240301082538.107373-1-m.kokryashkin@tarantool.org> (raw)

This patch makes use of reusable workflows from the
Tarantool repository, so now LuaJIT CI tests integration
in all relevant workflows.

Also, this patch disables MacOS testing for Tarantool
integration since those runs were made nightly in the
Tarantool repo.

As noted in the documentation[1], it is impossible for a single
workflow call tree to include more than 20 workflows. To
overcome this limitation, workflows are started in a bunch of
separate files. This makes it impossible to depend on LuaJIT-only
jobs for integration workflow since it is impossible to make
cross-dependencies between workflow files.

The name of a callee workflow cannot be substituted using a
matrix[2], so workflow calls are copied and pasted instead.

Table below shows which workflows are enabled and why.

Workflow name                   |+/-| Reason
-----------------------------------------------------------------
codeql                          | - | Not relevant to LuaJIT.
coverage                        | + | Long tests for profilers.
coverity                        | - | Cron workflow.
debug                           | + | Tarantool debug build.
debug_aarch64                   | + | Tarantool debug build.
debug_asan_clang                | + | Tarantool debug build.
default_gcc_centos_7            | + | Ancient gcc build.
freebsd                         | - | Nightly build.
fuzzing                         | - | Impossible to bump LuaJIT.
integration                     | + | Tarantool ecosystem.
jepsen-cluster-txm              | - | Manual workflow.
jepsen-cluster                  | - | Manual workflow.
jepsen-single-instance-txm      | - | Cron workflow.
jepsen-single-instance          | - | Cron workflow.
lango-stale-reviews             | - | Cron workflow.
lint                            | - | LuaJIT has its own lint.
luajit-integration              | + | Exotic LuaJIT options.
memtx_allocator_based_on_malloc | + | Not relevant to LuaJIT.
osx                             | - | Nightly build.
out_of_source                   | - | Not relevent to LuaJIT.
packaging                       | - | No LuaJIT-relevant variety.
perf_cbench                     | - | Not enabled for PRs.
perf_linkbench_ssd              | - | Not enabled for PRs.
perf_micro                      | - | Not relevant to LuaJIT.
perf_nosqlbench_hash            | - | Not enabled for PRs.
perf_nosqlbench_tree            | - | Not enabled for PRs.
perf_sysbench                   | - | Not enabled for PRs.
perf_tpcc                       | - | Not enabled for PRs.
perf_tpch                       | - | Not enabled for PRs.
perf_ycsb_hash                  | - | Not enabled for PRs.
perf_ycsb_tree                  | - | Not enabled for PRs.
publish-module-api-doc          | - | No Doxygen in LuaJIT.
release                         | + | Tarantool release build.
release_asan_clang              | + | Tarantool release build.
release_clang                   | + | Tarantool release build.
release_lto                     | + | Tarantool release build.
release_lto_clang               | + | Tarantool release build.
reusable_build                  | - | Utility for integration.
source                          | - | Not enabled for PRs.
static_build                    | + | Tarantool static build.
static_build_cmake_linux        | + | Tarantool static build.
static_build_pack_test_deploy   | - | Utility for packaging.
submodule_update                | - | Not enabled for PRs.

[1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations
[2]: https://github.com/orgs/community/discussions/45342#discussioncomment-4779360
---
Branch: https://github.com/tarantool/luajit/tree/fckxorg/integration-testing

 .github/workflows/exotic-tarantool.yml    |  62 ++++++++++++
 .github/workflows/tarantool-ecosystem.yml |  35 +++++++
 .github/workflows/testing.yml             | 116 ++++++++++++++++------
 3 files changed, 183 insertions(+), 30 deletions(-)
 create mode 100644 .github/workflows/exotic-tarantool.yml
 create mode 100644 .github/workflows/tarantool-ecosystem.yml

diff --git a/.github/workflows/exotic-tarantool.yml b/.github/workflows/exotic-tarantool.yml
new file mode 100644
index 00000000..be55291a
--- /dev/null
+++ b/.github/workflows/exotic-tarantool.yml
@@ -0,0 +1,62 @@
+name: "Exotic Tarantool builds testing"
+
+on:
+  push:
+    branches-ignore:
+      - '**-notest'
+      - 'upstream-**'
+    tags-ignore:
+      - '**'
+
+concurrency:
+  # An update of a developer branch cancels the previously
+  # scheduled workflow run for this branch. However, the default
+  # branch, and long-term branch (tarantool/release/2.11,
+  # tarantool/release/2.10, etc) workflow runs are never canceled.
+  #
+  # We use a trick here: define the concurrency group as 'workflow
+  # run ID' + # 'workflow run attempt' because it is a unique
+  # combination for any run. So it effectively discards grouping.
+  #
+  # XXX: we cannot use `github.sha` as a unique identifier because
+  # pushing a tag may cancel a run that works on a branch push
+  # event.
+  group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
+    && format('{0}-{1}', github.run_id, github.run_attempt)
+    || format('{0}-{1}', github.workflow, github.ref) }}
+  cancel-in-progress: true
+
+jobs:
+  test-exotic-tarantool:
+    strategy:
+      fail-fast: false
+      matrix:
+        ARCH: [ARM64, x86_64]
+        BUILDTYPE: [Debug, Release]
+        GC64: [ON, OFF]
+        OS: [Linux, macOS]
+        include:
+          - BUILDTYPE: Debug
+            CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug
+          - BUILDTYPE: Release
+            CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
+        exclude:
+          - ARCH: ARM64
+            GC64: OFF
+          - OS: macOS
+            GC64: OFF
+    name: >
+      Tarantool
+      (${{ matrix.OS }}/${{ matrix.ARCH }})
+      ${{ matrix.BUILDTYPE }}
+      GC64:${{ matrix.GC64 }}
+    # XXX: Only LuaJIT-tests are running in this workflow.
+    uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
+    with:
+      CMAKE_EXTRA_PARAMS: >
+        -G Ninja
+        ${{ matrix.CMAKEFLAGS }}
+        -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }}
+      arch: ${{ matrix.ARCH }}
+      os: ${{ matrix.OS }}
+      revision: ${{ github.sha }}
diff --git a/.github/workflows/tarantool-ecosystem.yml b/.github/workflows/tarantool-ecosystem.yml
new file mode 100644
index 00000000..82a47fe1
--- /dev/null
+++ b/.github/workflows/tarantool-ecosystem.yml
@@ -0,0 +1,35 @@
+name: Tarantool ecosystem integration testing
+
+on:
+  push:
+    branches-ignore:
+      - '**-notest'
+      - 'upstream-**'
+    tags-ignore:
+      - '**'
+
+concurrency:
+  # An update of a developer branch cancels the previously
+  # scheduled workflow run for this branch. However, the default
+  # branch, and long-term branch (tarantool/release/2.11,
+  # tarantool/release/2.10, etc) workflow runs are never canceled.
+  #
+  # We use a trick here: define the concurrency group as 'workflow
+  # run ID' + # 'workflow run attempt' because it is a unique
+  # combination for any run. So it effectively discards grouping.
+  #
+  # XXX: we cannot use `github.sha` as a unique identifier because
+  # pushing a tag may cancel a run that works on a branch push
+  # event.
+  group: ${{ startsWith(github.ref, 'refs/heads/tarantool/')
+    && format('{0}-{1}', github.run_id, github.run_attempt)
+    || format('{0}-{1}', github.workflow, github.ref) }}
+  cancel-in-progress: true
+
+jobs:
+  test-tarantool-integration:
+    uses: tarantool/tarantool/.github/workflows/integration.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
index cb4ba57b..7bd527be 100644
--- a/.github/workflows/testing.yml
+++ b/.github/workflows/testing.yml
@@ -83,37 +83,93 @@ jobs:
         run: cmake --build . --parallel --target LuaJIT-test
         working-directory: ${{ env.BUILDDIR }}

+  test-tarantool-coverage:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/coverage.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}

-  test-tarantool:
-    strategy:
-      fail-fast: false
-      matrix:
-        ARCH: [ARM64, x86_64]
-        BUILDTYPE: [Debug, Release]
-        GC64: [ON, OFF]
-        OS: [Linux, macOS]
-        include:
-          - BUILDTYPE: Debug
-            CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug
-          - BUILDTYPE: Release
-            CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
-        exclude:
-          - ARCH: ARM64
-            GC64: OFF
-          - OS: macOS
-            GC64: OFF
-    name: >
-      Tarantool
-      (${{ matrix.OS }}/${{ matrix.ARCH }})
-      ${{ matrix.BUILDTYPE }}
-      GC64:${{ matrix.GC64 }}
+  test-tarantool-debug:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/debug.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
+  test-tarantool-debug_aarch64:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/debug_aarch64.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
+  test-tarantool-debug_asan_clang:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/debug_asan_clang.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
+  test-tarantool-default_gcc_centos_7:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/default_gcc_centos_7.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
+  test-tarantool-out_of_source:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/out_of_source.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
+  test-tarantool-release:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/release.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
+  test-tarantool-release_asan_clang:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/release_asan_clang.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
+  test-tarantool-release_clang:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/release_clang.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
+  test-tarantool-release_lto:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/release_lto.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
+  test-tarantool-release_lto_clang:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/release_lto_clang.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
+  test-tarantool-static_build:
+    needs: test-luajit
+    uses: tarantool/tarantool/.github/workflows/static_build.yml@master
+    with:
+      submodule: luajit
+      revision: ${{ github.sha }}
+
+  test-tarantool-static_build_cmake_linux:
     needs: test-luajit
-    uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
+    uses: tarantool/tarantool/.github/workflows/static_build_cmake_linux.yml@master
     with:
-      CMAKE_EXTRA_PARAMS: >
-        -G Ninja
-        ${{ matrix.CMAKEFLAGS }}
-        -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }}
-      arch: ${{ matrix.ARCH }}
-      os: ${{ matrix.OS }}
+      submodule: luajit
       revision: ${{ github.sha }}
--
2.43.0


             reply	other threads:[~2024-03-01  8:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01  8:25 Maxim Kokryashkin via Tarantool-patches [this message]
2024-03-04 14:05 ` Sergey Bronnikov via Tarantool-patches
2024-03-06 20:40   ` Maxim Kokryashkin via Tarantool-patches
2024-03-04 16:45 ` Sergey Kaplun via Tarantool-patches
2024-03-06 20:34   ` Maxim Kokryashkin via Tarantool-patches
  -- strict thread matches above, loose matches on Subject: below --
2024-02-16 22:24 Maxim Kokryashkin via Tarantool-patches
2024-02-21 15:21 ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240301082538.107373-1-m.kokryashkin@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] ci: extend tarantool integration testing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox