From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D9FEC45FC08; Mon, 15 May 2023 12:17:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D9FEC45FC08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1684142249; bh=oBCNPxXFCn5jaxyYUW++XoFjtZRyK/KbKOUhNYcUj9c=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=HYayfnGRVsyMItzxCvdS8HG0TZ3QImz/3z8tQrFYwZgp4/iGPHfYD9lz8F8h9g3m0 MwyCg1XjuzxbV1+wsXbIQCzH/um4IRRyWEqCc5Ednmm9uHwViyHUogJBG5e43JjbIz 7btWU8TyczwR71rktuHspQmGdF6UUwal7Xf3qxRc= Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B28EA45FC05 for ; Mon, 15 May 2023 12:16:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B28EA45FC05 Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2ac733b813fso132533971fa.1 for ; Mon, 15 May 2023 02:16:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684142198; x=1686734198; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s8nsvj6wrNl+ZKBspoY0dHCRMzg5dKfAqFFSXfcUzpI=; b=YAo9AUxeqmRnKLwfJH4jwIZsFWoVs246N8s7g1AzQsx2iYoJ96yvEfcQdxczBlLMMm IXpseKDHjCahMSUon7JbPKWOcGwxkRA4Ahk1jZMUJGvLqU2Ui8MWOLvaUCmCyMWVh0Lw ovbr4yNY+qkX5bB73NKsNQq6yjWMVrYe2ZR6fO6Ek8+Jqq2Mlbs2cXYaeWkb0POd4JPT 9Rs4OojxDuFADKD30BlN3C3+CQTr3fjSkLiZ7y3N8Vpu+cMXP8lOmtv6JnDFgQZSb0rs eerb5nx7GwbIQrX9j5uWU1TS1fO77riyzlZ04vVotI7oFbX59jVV3UyizbpduvWXed14 1E9w== X-Gm-Message-State: AC+VfDyHoFoUsVgZEbmZe80uM7LEwHEtl8vGuFLalYGjKkg5ia9BMMkx Dq1iujeORndIcPrxMe7HefeSHeYf2/y/VMLc X-Google-Smtp-Source: ACHHUZ7c5Vr5/hFcgp52pH5nYnikQfSOucnBQr2CuuMRUMot0nFvOSSJryk+8fn6mTYaNQpYAQGhyQ== X-Received: by 2002:a2e:7e05:0:b0:2ad:ab12:e4ce with SMTP id z5-20020a2e7e05000000b002adab12e4cemr7014286ljc.7.1684142197542; Mon, 15 May 2023 02:16:37 -0700 (PDT) Received: from localhost.localdomain ([185.205.79.32]) by smtp.gmail.com with ESMTPSA id a4-20020a2e88c4000000b002ac7c9d2806sm3739607ljk.50.2023.05.15.02.16.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 15 May 2023 02:16:37 -0700 (PDT) To: tarantool-patches@dev.tarantool.org, sergos@tarantool.org, imun@tarantool.org, skaplun@tarantool.org, m.kokryashkin@tarantool.org Date: Mon, 15 May 2023 12:16:20 +0300 Message-Id: <20230515091622.30232-3-max.kokryashkin@gmail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230515091622.30232-1-max.kokryashkin@gmail.com> References: <20230515091622.30232-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH luajit v4 2/4] Disable unreliable assertion for external frame unwinding. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maksim Kokryashkin via Tarantool-patches Reply-To: Maksim Kokryashkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" From: Mike Pall Broken on Fedora/ARM64. Reported by Yichun Zhang. (cherry-picked from commit e957737650e060d5bf1c2909b741cc3dffe073ac) This patch disables the assertion that failed because of incorrectly constructed unwind information. That debug info generation was fixed in the scope of tarantool/tarantool#6096 with commit b731df1c0392cf7008be2e3c4112e1edb2392de4 ("ARM64: Reorder interpreter stack frame and fix unwinding.") This patch is backported only for consistency. Maxim Kokryashkin: * added the description for the problem Part of tarantool/tarantool#7745 Part of tarantool/tarantool#8069 Relates to tarantool/tarantool#6096 --- src/lj_err.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lj_err.c b/src/lj_err.c index c7fd9e65..f6200233 100644 --- a/src/lj_err.c +++ b/src/lj_err.c @@ -488,7 +488,9 @@ void lj_err_verify(void) ** lj_assertX(_Unwind_Find_FDE((void *)_Unwind_RaiseException, &ehb), "broken build: external frame unwinding enabled, but system libraries have no unwind tables"); */ lua_assert(_Unwind_Find_FDE((void *)lj_err_throw, &ehb)); + /* Check disabled, because of broken Fedora/ARM64. See #722. lua_assert(_Unwind_Find_FDE((void *)_Unwind_RaiseException, &ehb)); + */ } #endif -- 2.39.2 (Apple Git-143)