From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 13840254C7F; Tue, 28 Mar 2023 03:04:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 13840254C7F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1679961864; bh=2UB2jko4Xn7+TOwckWVvtP8UW9XlfBwxkIdlg1NYmS4=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=c3NuMoQ+5eLwz8db7SySDA5T94WNRapvzWVzwuCU4qlvENDgQd9KzhT7YAGtbdqMe hP5PAR0/gRmMR93mMmSx8JcUf4FqGH2j0umrlEjk/V/ebtYrEsF/4aln5nyZVza+8u 2om5tgIiiZy95x4hxl2Ul/nCieTJsvYDOTo4ejN4= Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 30B33254C7F for ; Tue, 28 Mar 2023 03:03:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 30B33254C7F Received: by mail-lj1-f175.google.com with SMTP id e11so10787477lji.8 for ; Mon, 27 Mar 2023 17:03:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679961811; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fW+vcTL0OYN/bs18s5xnRSj4ElFqwtM7t6UbyKbIC24=; b=ZhWDmuKygEpNA/FPniTNYjt7arqzA0rK8nSZhYsXFInWYeazIe7JhUSUysX+N9OsDL 9Oj0T3Kx0VQFGUNveN/2V89MatjMM3BxipDRzjEUGnaSh7eFhRgoQqAT2kgvj79uYH8j jISmhnHrr/NzzAYzayx/bdEzryNSmCFoGgsJksApmCGyGhN1K5OfqaIrukIiPF8G3eTW 6NYPrTOSON4sQ4eYEjanBJ/gccS+v/+9WopRZjQL8frtq0niSMkEKi8agjTYRhzR2w8H O5+kJChdfqKpWkYCAIjlQ4CFSdBVfELO1weI6irvSlVEiLqf6rM5t0gDOeQx5Cnlpx5x ZisA== X-Gm-Message-State: AAQBX9dicCHGqtCza5cVEuQ3D6rc+VazWs/XEOCqOadY3I8zVnNcqaHc JDglpUsSSHrUmh7SCiNQaKFffweAlKRpHg== X-Google-Smtp-Source: AKy350bKWmqFSnG4tLcxdOzHDumO72h+cAMi254gpvHwWwlhjnJ2BpqgL9SrnkCWW/E4nQuNAW4mpw== X-Received: by 2002:a2e:7c06:0:b0:2a4:44a5:d4a3 with SMTP id x6-20020a2e7c06000000b002a444a5d4a3mr3710577ljc.0.1679961810913; Mon, 27 Mar 2023 17:03:30 -0700 (PDT) Received: from localhost.localdomain (89-179-106-78.broadband.corbina.ru. [89.179.106.78]) by smtp.gmail.com with ESMTPSA id x9-20020a2e7c09000000b00298a81f5d70sm4837508ljc.136.2023.03.27.17.03.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 27 Mar 2023 17:03:30 -0700 (PDT) To: tarantool-patches@dev.tarantool.org, sergos@tarantool.org, skaplun@tarantool.org, m.kokryashkin@tarantool.org Date: Tue, 28 Mar 2023 03:03:15 +0300 Message-Id: <20230328000317.33238-3-max.kokryashkin@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) In-Reply-To: <20230328000317.33238-1-max.kokryashkin@gmail.com> References: <20230328000317.33238-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH luajit v3 2/4] Disable unreliable assertion for external frame unwinding. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maksim Kokryashkin via Tarantool-patches Reply-To: Maksim Kokryashkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" From: Mike Pall Broken on Fedora/ARM64. Reported by Yichun Zhang. (cherry-picked from commit e957737650e060d5bf1c2909b741cc3dffe073ac) This patch disables the assertion that failed because of incorrectly constructed unwind information. That debug info generation was fixed in the scope of tarantool/tarantool#6096 with commit b731df1c0392cf7008be2e3c4112e1edb2392de4 ("ARM64: Reorder interpreter stack frame and fix unwinding.") This patch is backported only for consistency. Maxim Kokryashkin: * added the description for the problem Part of tarantool/tarantool#7745 Part of tarantool/tarantool#8069 Relates to tarantool/tarantool#6096 --- src/lj_err.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lj_err.c b/src/lj_err.c index c7fd9e65..f6200233 100644 --- a/src/lj_err.c +++ b/src/lj_err.c @@ -488,7 +488,9 @@ void lj_err_verify(void) ** lj_assertX(_Unwind_Find_FDE((void *)_Unwind_RaiseException, &ehb), "broken build: external frame unwinding enabled, but system libraries have no unwind tables"); */ lua_assert(_Unwind_Find_FDE((void *)lj_err_throw, &ehb)); + /* Check disabled, because of broken Fedora/ARM64. See #722. lua_assert(_Unwind_Find_FDE((void *)_Unwind_RaiseException, &ehb)); + */ } #endif -- 2.37.1 (Apple Git-137.1)