Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [Tarantool-patches] [RFC v29 0/3] qsync: implement packet filtering (part 1)
Date: Tue,  1 Feb 2022 00:55:51 +0300	[thread overview]
Message-ID: <20220131215554.1367429-1-gorcunov@gmail.com> (raw)

Guys, here is an updated version, where test is converted into luatest
form and box_issue_promote/issue_demote are fenced out with a lock.
Take a look please. It is still RFC since I didn't managed yet to
enhance the test for promote/demote requests as Serge suggested.
Still I would like to make sure that except the test there is
nothing i forget to address from previsous comments.

v22 (by SergeP):
 - use limbo emptiness test _after_ owner_id test
 - drop redundant assert in limbo commit/rollback
   since we're unlocking a latch anyway where own
   assertion present
 - in test: drop excessive wait_cond and setup wal
   delay earlier

v23 (by SergeP):
 - fix problem with owner test in case of recovery journal
 - update test

 - simplify the code and cover the case targeting journal
   write plus terms access race only
 - i've spent almost a few months trying to use fine grained
   locking scheme for limbo but it end up in very complex code
   so eventually I dropped this idea (here why we've v27 after v23)

 - rework test into luaform
 - drop fine-grained locks idea since it requires too much code churn,
   instead lets fence out a big code parts

branch gorcunov/gh-6036-rollback-confirm-29-notest
issue https://github.com/tarantool/tarantool/issues/6036
previous series https://lists.tarantool.org/tarantool-patches/20211230202347.353494-1-gorcunov@gmail.com/#r

Cyrill Gorcunov (3):
  latch: add latch_is_locked helper
  qsync: order access to the limbo terms
  test: add gh-6036-qsync-order test

 src/box/applier.cc                            |   6 +-
 src/box/box.cc                                |   8 +-
 src/box/lua/info.c                            |   4 +-
 src/box/txn_limbo.c                           |  18 ++-
 src/box/txn_limbo.h                           |  52 ++++++-
 src/lib/core/latch.h                          |  11 ++
 .../gh_6036_qsync_order_test.lua              | 137 ++++++++++++++++++
 test/replication-luatest/suite.ini            |   1 +
 8 files changed, 226 insertions(+), 11 deletions(-)
 create mode 100644 test/replication-luatest/gh_6036_qsync_order_test.lua

base-commit: b72a5c6a1b66d983ca58ac73ecc147e5ab8dd5b3

             reply	other threads:[~2022-01-31 21:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 21:55 Cyrill Gorcunov via Tarantool-patches [this message]
2022-01-31 21:55 ` [Tarantool-patches] [RFC v29 1/3] latch: add latch_is_locked helper Cyrill Gorcunov via Tarantool-patches
2022-01-31 21:55 ` [Tarantool-patches] [RFC v29 2/3] qsync: order access to the limbo terms Cyrill Gorcunov via Tarantool-patches
2022-02-09  9:10   ` Serge Petrenko via Tarantool-patches
2022-01-31 21:55 ` [Tarantool-patches] [RFC v29 3/3] test: add gh-6036-qsync-order test Cyrill Gorcunov via Tarantool-patches
2022-02-09  9:11   ` Serge Petrenko via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220131215554.1367429-1-gorcunov@gmail.com \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [RFC v29 0/3] qsync: implement packet filtering (part 1)' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox