From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] test: fix dynamic modules loading on macOS
Date: Thu, 30 Dec 2021 09:59:59 +0000 [thread overview]
Message-ID: <20211230095959.ta2cvadiruemrnij@tarantool.org> (raw)
In-Reply-To: <20211229115810.22661-1-skaplun@tarantool.org>
Hello,
On 29 дек 14:58, Sergey Kaplun wrote:
> Since the auxiliary libraries are built as dynamically loaded modules on
> macOS instead of shared libraries as it is done on Linux and BSD,
> another environment variable should be used to guide `ffi.load()` while
> searching the extension. Hence the paths are set in test need to be set
> to `DYLD_LIBRARY_PATH` variable instead of `LD_LIBRARY_PATH` on macOS.
> ---
>
> Branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-noticket-fix-macos-fiber-switch-test-full-ci
LGTM.
I've checked your patch into 1.10, 2.8 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2021-12-30 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 11:58 Sergey Kaplun via Tarantool-patches
2021-12-30 9:59 ` Kirill Yukhin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211230095959.ta2cvadiruemrnij@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] test: fix dynamic modules loading on macOS' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox