From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2C6726ECC0; Wed, 8 Dec 2021 14:25:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2C6726ECC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1638962758; bh=gj1/b/U5EGiRjkEWQuy3vbnVFX7W1HwM3N7fJfMCLhA=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=LnpYVkXC0g5ycA4p1C3upjJoTkNG16rsUoO0tqL7EvswR4Yl89oPhiKa+7MuFuOK1 QAH1e4IQswB+OB7B5wyKs23qYm7laRpTE4J0FzmwQg7ocFtYNfgngpGqfoA2Sp0UXw dHRMKbeYrFLOrSPCdiksgzLHAm6FoUgE1Ob4uqC0= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B4F2B6ECC0 for ; Wed, 8 Dec 2021 14:25:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B4F2B6ECC0 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1muv59-0003nx-RH; Wed, 08 Dec 2021 14:25:56 +0300 Date: Wed, 8 Dec 2021 14:25:54 +0300 To: Serge Petrenko Cc: Serge Petrenko via Tarantool-patches Message-ID: <20211208112554.xdyltiuxuqfzqu4x@esperanza> References: <20211208104454.20345-1-sergepetrenko@tarantool.org> <20211208110050.ntfyrjifksrw5hw4@esperanza> <5169d323-4c8f-d7d2-3344-32fcad5c2d5d@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5169d323-4c8f-d7d2-3344-32fcad5c2d5d@tarantool.org> X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD99F281DB1F96F126D534E8139A8CF339D45AFDC12F08E1E9F00894C459B0CD1B9F7CF4286513016F755DD4B713A55C028C3795C782B397F880C2C9DC93A1268B0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063707C4856229E8E7E48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84366A29C1AD25EFE37B85C47C7911A19117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6AC294AFEFA671E80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A580A9A2A04EE6262F591D04D7567D09677E6598A832A72386D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA755C623DA9A0966939410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B5900AD87B4159A4FEA9B5FCC40AF3937ACBCB05ADAE9B83E28B1497A78DF84CEC5120A00D3D33121D7E09C32AA3244C615604031C3C68DEFAE50A6C5BCE52433A92A9747B6CC886FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnkZtajpA89XOyXiq9sWcYA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DC250D536114492370B9913B0C17BC664274CEFED1673C562683ABF942079399BFB559BB5D741EB966A65DFF43FF7BE03240331F90058701C5FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] replication: fix flaky gh-3160-misc... test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladimir Davydov via Tarantool-patches Reply-To: Vladimir Davydov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Dec 08, 2021 at 02:13:04PM +0300, Serge Petrenko wrote: > > > 08.12.2021 14:00, Vladimir Davydov via Tarantool-patches пишет: > > Merged into master, 2.8, 1.10. > > > > Please don't send emails. PR is enough :-) > > Some people prefer emails over PRs. > > I think everyone should review the patches where it suits > them best, so I open PRs for you and send emails to Vlad. > (even though this is double the hustle). This is confusing. I noticed the email only after I merged the PR. In the PR, I was the only reviewer so I reckoned it's okay to merge, but it turned out the patch was also sent to Vlad via email... Also, when the same patch is reviewed both via email and PR, the same comment might be raised twice by different reviewers or reviewers may suggest different things being not aware of each other's arguments and you'll have to reconcile. Vlad can review patches in PRs AFAICS - he reviews my patches in PRs, for instance.